summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2015-02-28 15:26:01 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2015-02-28 15:26:01 -0500
commit0a629e73297905462d4072f330d2389f5fc6d839 (patch)
tree33aa25185099f78c0883bfe63d6b3a404b36c8cd /lib/sqlalchemy
parentc2cdd32f8ba09b070386143527fa42c28bf528ee (diff)
downloadsqlalchemy-0a629e73297905462d4072f330d2389f5fc6d839.tar.gz
- wrong! I didn't have the cprocs on the master test. we are barely
slower. we do save on single queries, however. - but...wrong! we still can't do this approach for eager loads. we don't have context.outer_adapter available when we set up "quick" here, so this can't work.
Diffstat (limited to 'lib/sqlalchemy')
-rw-r--r--lib/sqlalchemy/orm/strategies.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py
index 95ed198a5..41f678955 100644
--- a/lib/sqlalchemy/orm/strategies.py
+++ b/lib/sqlalchemy/orm/strategies.py
@@ -148,6 +148,11 @@ class ColumnLoader(LoaderStrategy):
# the column on the base table. More specific logic
# should be added here so that we need not bother
# querying out every column.
+
+ # TODO: wrong. we are again fetching by column and we are
+ # not applying context.outer_adapter if we're in the primary
+ # collection. Also, context.outer_adapter
+ # isn't even set up yet. So again, we can't do this.
populators["quick"].append(
(self.key, operator.itemgetter(self.columns[0]))
)