From 0a629e73297905462d4072f330d2389f5fc6d839 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 28 Feb 2015 15:26:01 -0500 Subject: - wrong! I didn't have the cprocs on the master test. we are barely slower. we do save on single queries, however. - but...wrong! we still can't do this approach for eager loads. we don't have context.outer_adapter available when we set up "quick" here, so this can't work. --- lib/sqlalchemy/orm/strategies.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'lib/sqlalchemy') diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py index 95ed198a5..41f678955 100644 --- a/lib/sqlalchemy/orm/strategies.py +++ b/lib/sqlalchemy/orm/strategies.py @@ -148,6 +148,11 @@ class ColumnLoader(LoaderStrategy): # the column on the base table. More specific logic # should be added here so that we need not bother # querying out every column. + + # TODO: wrong. we are again fetching by column and we are + # not applying context.outer_adapter if we're in the primary + # collection. Also, context.outer_adapter + # isn't even set up yet. So again, we can't do this. populators["quick"].append( (self.key, operator.itemgetter(self.columns[0])) ) -- cgit v1.2.1