summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/testing
diff options
context:
space:
mode:
authormike bayer <mike_mp@zzzcomputing.com>2023-05-09 17:55:16 +0000
committerGerrit Code Review <gerrit@bbpush.zzzcomputing.com>2023-05-09 17:55:16 +0000
commitcef8adac8ae48c5c6c36138ed0b59067c1ef78ed (patch)
tree4ec5b5dc56e8bd700baf2d4e5d7b49d2c806802b /lib/sqlalchemy/testing
parent4e3806861b19a00203f95b6ecbe411a4e252d152 (diff)
parentff821e57c960f095ab2988a0f892b3127374f498 (diff)
downloadsqlalchemy-cef8adac8ae48c5c6c36138ed0b59067c1ef78ed.tar.gz
Merge "Ensure float are not implemented as numeric" into main
Diffstat (limited to 'lib/sqlalchemy/testing')
-rw-r--r--lib/sqlalchemy/testing/requirements.py6
-rw-r--r--lib/sqlalchemy/testing/suite/test_types.py11
2 files changed, 17 insertions, 0 deletions
diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py
index a2a9dc822..6fb629bf9 100644
--- a/lib/sqlalchemy/testing/requirements.py
+++ b/lib/sqlalchemy/testing/requirements.py
@@ -1254,6 +1254,12 @@ class SuiteRequirements(Requirements):
return exclusions.open()
@property
+ def float_is_numeric(self):
+ """target backend uses Numeric for Float/Dual"""
+
+ return exclusions.open()
+
+ @property
def text_type(self):
"""Target database must support an unbounded Text() "
"type such as TEXT or CLOB"""
diff --git a/lib/sqlalchemy/testing/suite/test_types.py b/lib/sqlalchemy/testing/suite/test_types.py
index ba2dda9ef..b93d65bec 100644
--- a/lib/sqlalchemy/testing/suite/test_types.py
+++ b/lib/sqlalchemy/testing/suite/test_types.py
@@ -13,6 +13,7 @@ from .. import fixtures
from .. import mock
from ..assertions import eq_
from ..assertions import is_
+from ..assertions import ne_
from ..config import requirements
from ..schema import Column
from ..schema import Table
@@ -49,6 +50,7 @@ from ... import Uuid
from ...dialects.postgresql import BYTEA
from ...orm import declarative_base
from ...orm import Session
+from ...sql import sqltypes
from ...sql.sqltypes import LargeBinary
from ...sql.sqltypes import PickleType
@@ -1154,6 +1156,15 @@ class NumericTest(_LiteralRoundTripFixture, fixtures.TestBase):
Numeric(precision=5, scale=3), numbers, numbers, check_scale=True
)
+ @testing.combinations(sqltypes.Float, sqltypes.Double, argnames="cls_")
+ @testing.requires.float_is_numeric
+ def test_float_is_not_numeric(self, connection, cls_):
+ target_type = cls_().dialect_impl(connection.dialect)
+ numeric_type = sqltypes.Numeric().dialect_impl(connection.dialect)
+
+ ne_(target_type.__visit_name__, numeric_type.__visit_name__)
+ ne_(target_type.__class__, numeric_type.__class__)
+
class BooleanTest(_LiteralRoundTripFixture, fixtures.TablesTest):
__backend__ = True