diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-07-28 15:05:25 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-07-28 17:36:08 -0400 |
| commit | 7997d7fdc3634e7dba9fd0113b8b85ef311bfeaa (patch) | |
| tree | 43deaf3902525a018b712d874494bfd45a245ec6 /lib/sqlalchemy/testing/plugin/plugin_base.py | |
| parent | 54670897701fa9b30ac3dd3cdb1511960e338e01 (diff) | |
| download | sqlalchemy-7997d7fdc3634e7dba9fd0113b8b85ef311bfeaa.tar.gz | |
Revert cx_Oracle WITH_UNICODE change under > 5.0
Fixed performance regression caused by the fix for :ticket:`3937` where
cx_Oracle as of version 5.3 dropped the ``.UNICODE`` symbol from its
namespace, which was interpreted as cx_Oracle's "WITH_UNICODE" mode being
turned on unconditionally, which invokes functions on the SQLAlchemy
side which convert all strings to unicode unconditionally and causing
a performance impact. In fact, per cx_Oracle's author the
"WITH_UNICODE" mode has been removed entirely as of 5.1, so the expensive unicode
conversion functions are no longer necessary and are disabled if
cx_Oracle 5.1 or greater is detected under Python 2. The warning against
"WITH_UNICODE" mode that was removed under :ticket:`3937` is also restored.
Change-Id: Iddd38d81a5adb27c953a5ee2eae5529a21da16e1
Fixes: #4035
Diffstat (limited to 'lib/sqlalchemy/testing/plugin/plugin_base.py')
0 files changed, 0 insertions, 0 deletions