summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2015-03-09 14:36:23 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2015-03-09 14:36:23 -0400
commit9afe585f4599d8114abe8d11f924c206a8962cda (patch)
treedd734140049a3f0e744f43791bdf18971f33bbe6 /lib/sqlalchemy/sql
parentfcfa62bd76ee0cdb125f0eb46ec4c1f625cbd6e7 (diff)
downloadsqlalchemy-9afe585f4599d8114abe8d11f924c206a8962cda.tar.gz
- pick around gaining modest dings in callcounts here and there
Diffstat (limited to 'lib/sqlalchemy/sql')
-rw-r--r--lib/sqlalchemy/sql/selectable.py5
-rw-r--r--lib/sqlalchemy/sql/visitors.py14
2 files changed, 16 insertions, 3 deletions
diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py
index 3384939b0..42d2e4e12 100644
--- a/lib/sqlalchemy/sql/selectable.py
+++ b/lib/sqlalchemy/sql/selectable.py
@@ -43,9 +43,10 @@ def _interpret_as_from(element):
{"expr": util.ellipses_string(element)})
return TextClause(util.text_type(element))
- elif hasattr(insp, "selectable"):
+ try:
return insp.selectable
- raise exc.ArgumentError("FROM expression expected")
+ except AttributeError:
+ raise exc.ArgumentError("FROM expression expected")
def _interpret_as_select(element):
diff --git a/lib/sqlalchemy/sql/visitors.py b/lib/sqlalchemy/sql/visitors.py
index d09b82148..b53b44eec 100644
--- a/lib/sqlalchemy/sql/visitors.py
+++ b/lib/sqlalchemy/sql/visitors.py
@@ -213,12 +213,19 @@ def iterate(obj, opts):
traversal is configured to be breadth-first.
"""
+ # fasttrack for atomic elements like columns
+ children = obj.get_children(**opts)
+ if not children:
+ return [obj]
+
+ traversal = deque()
stack = deque([obj])
while stack:
t = stack.popleft()
- yield t
+ traversal.append(t)
for c in t.get_children(**opts):
stack.append(c)
+ return iter(traversal)
def iterate_depthfirst(obj, opts):
@@ -227,6 +234,11 @@ def iterate_depthfirst(obj, opts):
traversal is configured to be depth-first.
"""
+ # fasttrack for atomic elements like columns
+ children = obj.get_children(**opts)
+ if not children:
+ return [obj]
+
stack = deque([obj])
traversal = deque()
while stack: