diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-08-25 15:26:02 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-08-25 16:53:49 -0400 |
| commit | 2392ae1900f112c44ed966783d1dedfb88f13353 (patch) | |
| tree | 405791ed1dacde958b0e5be9f4a36bd66190345e /lib/sqlalchemy/sql | |
| parent | 887fb3ebaad20847edc752f5fcf072ace947d56a (diff) | |
| download | sqlalchemy-2392ae1900f112c44ed966783d1dedfb88f13353.tar.gz | |
Apply percent sign escaping to literal binds, comments
Fixed bug in new percent-sign support (e.g. :ticket:`3740`) where a bound
parameter rendered with literal_binds would fail to escape percent-signs
for relevant dialects. In addition, ensured new table / column comment
support feature also fully makes use of literal-rendered parameters so that
this percent sign support takes place with table / column comment DDL as
well, allowing percent sign support for the mysql / psycopg2 backends that
require escaping of percent signs.
Change-Id: Ia4136a300933e9bc6a01a7b9afd5c7b9a3fee4e3
Fixes: #4054
Fixes: #4052
Diffstat (limited to 'lib/sqlalchemy/sql')
| -rw-r--r-- | lib/sqlalchemy/sql/sqltypes.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/sqlalchemy/sql/sqltypes.py b/lib/sqlalchemy/sql/sqltypes.py index 6838baa5f..fe9a56b6e 100644 --- a/lib/sqlalchemy/sql/sqltypes.py +++ b/lib/sqlalchemy/sql/sqltypes.py @@ -205,6 +205,10 @@ class String(Concatenable, TypeEngine): def literal_processor(self, dialect): def process(value): value = value.replace("'", "''") + + if dialect.identifier_preparer._double_percents: + value = value.replace('%', '%%') + return "'%s'" % value return process |