diff options
author | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-09-07 20:38:00 -0400 |
---|---|---|
committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2017-09-07 20:39:48 -0400 |
commit | 60fec8d2f19d8134df06b9cc63c52aae27c9dcfe (patch) | |
tree | ce212e6eaf0ec575240f6527c04e70e4cf756d78 /lib/sqlalchemy/orm/strategies.py | |
parent | 2e137b3954f57c0b2e1977419ccecda35b5265b2 (diff) | |
download | sqlalchemy-ticket_4071.tar.gz |
Remove LRU warningsticket_4071
Removed the warnings that are emitted when the LRU caches employed
by the mapper as well as loader srtategies reach their threshold; the
purpose of this warning was at first a guard against excess cache keys
being generated but became basically a check on the "creating many
engines" antipattern. While this is still an antipattern, the presense
of test suites which both create an engine per test as well as raise
on all warnings will be an inconvenience; it should not be critical
that such test suites change their architecture just for this warning
(though engine-per-test suite is always better).
Change-Id: I41ef8cd642d05a845f53119b196440f9d7879cd9
Fixes: #4071
Diffstat (limited to 'lib/sqlalchemy/orm/strategies.py')
-rw-r--r-- | lib/sqlalchemy/orm/strategies.py | 26 |
1 files changed, 2 insertions, 24 deletions
diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py index 11ebcee50..a57b66045 100644 --- a/lib/sqlalchemy/orm/strategies.py +++ b/lib/sqlalchemy/orm/strategies.py @@ -643,18 +643,7 @@ class LazyLoader(AbstractRelationshipLoader, util.MemoizedSlots): @util.dependencies("sqlalchemy.ext.baked") def _memoized_attr__bakery(self, baked): - return baked.bakery(size=50, _size_alert=self._alert_lru_cache_limit) - - def _alert_lru_cache_limit(self, lru_cache): - util.warn( - "Compiled statement cache for lazy loader on attribute %s is " - "reaching its size threshold of %d. Consider setting " - "bake_queries=False for this relationship. Please refer to " - "http://docs.sqlalchemy.org/en/latest/faq/performance.html" - "#faq_compiled_cache_threshold" - " for best practices." % - (self.parent_property, - lru_cache.size_threshold)) + return baked.bakery(size=50) @util.dependencies( "sqlalchemy.orm.strategy_options") @@ -1851,18 +1840,7 @@ class SelectInLoader(AbstractRelationshipLoader, util.MemoizedSlots): @util.dependencies("sqlalchemy.ext.baked") def _memoized_attr__bakery(self, baked): - return baked.bakery(size=50, _size_alert=self._alert_lru_cache_limit) - - def _alert_lru_cache_limit(self, lru_cache): - util.warn( - "Compiled statement cache for selectin loader on attribute %s is " - "reaching its size threshold of %d. Consider setting " - "bake_queries=False for this relationship. Please refer to " - "http://docs.sqlalchemy.org/en/latest/faq/performance.html" - "#faq_compiled_cache_threshold" - " for best practices." % - (self.parent_property, - lru_cache.size_threshold)) + return baked.bakery(size=50) def create_row_processor( self, context, path, loadopt, mapper, |