summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/engine
diff options
context:
space:
mode:
authormike bayer <mike_mp@zzzcomputing.com>2022-09-20 02:34:31 +0000
committerGerrit Code Review <gerrit@ci3.zzzcomputing.com>2022-09-20 02:34:31 +0000
commit214d1ad7c38deebec6547da22b99c0a4804bf820 (patch)
tree730b18fefc3dfd0ca4c39ef20c14c0e9fec0eb68 /lib/sqlalchemy/engine
parentaab6005dda456c8647192cd62064c67e6a5558ff (diff)
parentc9af2ebf5e5d288aea3a3a26bdf950e08ac4f927 (diff)
downloadsqlalchemy-214d1ad7c38deebec6547da22b99c0a4804bf820.tar.gz
Merge "break out text() from TextualSelect for col matching" into main
Diffstat (limited to 'lib/sqlalchemy/engine')
-rw-r--r--lib/sqlalchemy/engine/cursor.py16
-rw-r--r--lib/sqlalchemy/engine/default.py3
2 files changed, 15 insertions, 4 deletions
diff --git a/lib/sqlalchemy/engine/cursor.py b/lib/sqlalchemy/engine/cursor.py
index 0204fbbbb..8840b5916 100644
--- a/lib/sqlalchemy/engine/cursor.py
+++ b/lib/sqlalchemy/engine/cursor.py
@@ -237,6 +237,7 @@ class CursorResultMetaData(ResultMetaData):
result_columns,
cols_are_ordered,
textual_ordered,
+ ad_hoc_textual,
loose_column_name_matching,
) = context.result_column_struct
num_ctx_cols = len(result_columns)
@@ -245,6 +246,8 @@ class CursorResultMetaData(ResultMetaData):
cols_are_ordered
) = (
num_ctx_cols
+ ) = (
+ ad_hoc_textual
) = loose_column_name_matching = textual_ordered = False
# merge cursor.description with the column info
@@ -256,6 +259,7 @@ class CursorResultMetaData(ResultMetaData):
num_ctx_cols,
cols_are_ordered,
textual_ordered,
+ ad_hoc_textual,
loose_column_name_matching,
)
@@ -282,8 +286,11 @@ class CursorResultMetaData(ResultMetaData):
}
if len(by_key) != num_ctx_cols:
- # if by-primary-string dictionary smaller (or bigger?!) than
- # number of columns, assume we have dupes, rewrite
+ # if by-primary-string dictionary smaller than
+ # number of columns, assume we have dupes; (this check
+ # is also in place if string dictionary is bigger, as
+ # can occur when '*' was used as one of the compiled columns,
+ # which may or may not be suggestive of dupes), rewrite
# dupe records with "None" for index which results in
# ambiguous column exception when accessed.
#
@@ -368,6 +375,7 @@ class CursorResultMetaData(ResultMetaData):
num_ctx_cols,
cols_are_ordered,
textual_ordered,
+ ad_hoc_textual,
loose_column_name_matching,
):
"""Merge a cursor.description with compiled result column information.
@@ -461,7 +469,9 @@ class CursorResultMetaData(ResultMetaData):
# name-based or text-positional cases, where we need
# to read cursor.description names
- if textual_ordered:
+ if textual_ordered or (
+ ad_hoc_textual and len(cursor_description) == num_ctx_cols
+ ):
self._safe_for_cache = True
# textual positional case
raw_iterator = self._merge_textual_cols_by_position(
diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py
index 9ad0ebbfc..3a53f8157 100644
--- a/lib/sqlalchemy/engine/default.py
+++ b/lib/sqlalchemy/engine/default.py
@@ -939,7 +939,7 @@ class DefaultExecutionContext(ExecutionContext):
executemany = False
compiled: Optional[Compiled] = None
result_column_struct: Optional[
- Tuple[List[ResultColumnsEntry], bool, bool, bool]
+ Tuple[List[ResultColumnsEntry], bool, bool, bool, bool]
] = None
returned_default_rows: Optional[Sequence[Row[Any]]] = None
@@ -1057,6 +1057,7 @@ class DefaultExecutionContext(ExecutionContext):
compiled._result_columns,
compiled._ordered_columns,
compiled._textual_ordered_columns,
+ compiled._ad_hoc_textual,
compiled._loose_column_name_matching,
)