summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/dialects/mysql
diff options
context:
space:
mode:
authorFederico Caselli <cfederico87@gmail.com>2021-04-21 22:49:09 +0200
committerMike Bayer <mike_mp@zzzcomputing.com>2021-04-28 20:03:27 -0400
commitd3c73ad8012e15bf47529b3fcb0bac1298fbdb90 (patch)
tree31ae2c420b9d58d55e56a9191a34176c1deb7c16 /lib/sqlalchemy/dialects/mysql
parent1443945e61f1f113e46a5044315a91558d4d232a (diff)
downloadsqlalchemy-d3c73ad8012e15bf47529b3fcb0bac1298fbdb90.tar.gz
Propertly ignore ``Identity`` in MySQL and MariaDb.
Ensure that the MySQL and MariaDB dialect ignore the :class:`_sql.Identity` construct while rendering the ``AUTO_INCREMENT`` keyword in a create table. The Oracle and PostgreSQL compiler was updated to not render :class:`_sql.Identity` if the database version does not support it (Oracle < 12 and PostgreSQL < 10). Previously it was rendered regardless of the database version. Fixes: #6338 Change-Id: I2ca0902fdd7b4be4fc1a563cf5585504cbea9360
Diffstat (limited to 'lib/sqlalchemy/dialects/mysql')
-rw-r--r--lib/sqlalchemy/dialects/mysql/base.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py
index d4c70a78e..88c03a011 100644
--- a/lib/sqlalchemy/dialects/mysql/base.py
+++ b/lib/sqlalchemy/dialects/mysql/base.py
@@ -1933,7 +1933,10 @@ class MySQLDDLCompiler(compiler.DDLCompiler):
if (
column.table is not None
and column is column.table._autoincrement_column
- and column.server_default is None
+ and (
+ column.server_default is None
+ or isinstance(column.server_default, sa_schema.Identity)
+ )
and not (
self.dialect.supports_sequences
and isinstance(column.default, sa_schema.Sequence)