diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2016-10-04 11:17:26 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2016-10-04 11:17:26 -0400 |
| commit | f0ea9e37f94bd39fa4f0785dbdcd0ee1759c4a11 (patch) | |
| tree | 1010a692ac8a75339970b3adf46c59248c23d454 /lib/sqlalchemy/connectors | |
| parent | 728ce8cc480d0ada690e5a97067cff821b9a65f3 (diff) | |
| download | sqlalchemy-f0ea9e37f94bd39fa4f0785dbdcd0ee1759c4a11.tar.gz | |
Use SQL Server SERVERPROPERTY for version info w/ pyodbc
Updated the server version info scheme for pyodbc to use SQL Server
SERVERPROPERTY(), rather than relying upon pyodbc.SQL_DBMS_VER, which
continues to be unreliable particularly with FreeTDS.
Change-Id: I4ff49ae13c8ff51bd764980131d41c18d73d87ce
Fixes: #3814
Diffstat (limited to 'lib/sqlalchemy/connectors')
| -rw-r--r-- | lib/sqlalchemy/connectors/pyodbc.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py index 68bbcc435..1811229d7 100644 --- a/lib/sqlalchemy/connectors/pyodbc.py +++ b/lib/sqlalchemy/connectors/pyodbc.py @@ -153,7 +153,6 @@ class PyODBCConnector(Connector): # run other initialization which asks for user name, etc. super(PyODBCConnector, self).initialize(connection) - def _dbapi_version(self): if not self.dbapi: return () @@ -172,6 +171,9 @@ class PyODBCConnector(Connector): return vers def _get_server_version_info(self, connection): + # NOTE: this function is not reliable, particularly when + # freetds is in use. Implement database-specific server version + # queries. dbapi_con = connection.connection version = [] r = re.compile('[.\-]') |