From f0ea9e37f94bd39fa4f0785dbdcd0ee1759c4a11 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Tue, 4 Oct 2016 11:17:26 -0400 Subject: Use SQL Server SERVERPROPERTY for version info w/ pyodbc Updated the server version info scheme for pyodbc to use SQL Server SERVERPROPERTY(), rather than relying upon pyodbc.SQL_DBMS_VER, which continues to be unreliable particularly with FreeTDS. Change-Id: I4ff49ae13c8ff51bd764980131d41c18d73d87ce Fixes: #3814 --- lib/sqlalchemy/connectors/pyodbc.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/sqlalchemy/connectors') diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py index 68bbcc435..1811229d7 100644 --- a/lib/sqlalchemy/connectors/pyodbc.py +++ b/lib/sqlalchemy/connectors/pyodbc.py @@ -153,7 +153,6 @@ class PyODBCConnector(Connector): # run other initialization which asks for user name, etc. super(PyODBCConnector, self).initialize(connection) - def _dbapi_version(self): if not self.dbapi: return () @@ -172,6 +171,9 @@ class PyODBCConnector(Connector): return vers def _get_server_version_info(self, connection): + # NOTE: this function is not reliable, particularly when + # freetds is in use. Implement database-specific server version + # queries. dbapi_con = connection.connection version = [] r = re.compile('[.\-]') -- cgit v1.2.1