diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-05-14 10:51:29 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-05-14 10:51:29 -0400 |
| commit | 79de84b25e87bbb7fa94f0dd513b4abc76e05a7e (patch) | |
| tree | 051638d4e5838e7cfe13ee22db8c2ef5837c82c4 /doc | |
| parent | 6bd171cbc87db8ca55640bd7efd8c88a44d08808 (diff) | |
| download | sqlalchemy-79de84b25e87bbb7fa94f0dd513b4abc76e05a7e.tar.gz | |
Actively unset reset agent in discard transaction
The assumptions in _discard_transaction from
916e1fea25afcd07fa1d1d2f72043b372cd02223 were too narrow,
assuming that if the given transaction were not our
"current" one, that this would not be the reset agent. however
as the legacy behvaior is that even a "nested" transaction gets
set as "self._transaction", this did not accommodate for the nested
transaction being thrown away. We will attempt to refine all of this
logic in #5327 for 1.4 /master assuming this is feasible for the
full suite of current use cases.
Fixes: #5326
Change-Id: I6787e82c9e50c23317f87d0d094122c6a6f066da
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/build/changelog/unreleased_13/5326.rst | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/doc/build/changelog/unreleased_13/5326.rst b/doc/build/changelog/unreleased_13/5326.rst new file mode 100644 index 000000000..801ff4a42 --- /dev/null +++ b/doc/build/changelog/unreleased_13/5326.rst @@ -0,0 +1,9 @@ +.. change:: + :tags: bug, engine + :tickets: 5326 + + Further refinements to the fixes to the "reset" agent fixed in + :ticket:`5326`, which now emits a warning when it is not being correctly + invoked and corrects for the behavior. Additional scenarios have been + identified and fixed where this warning was being emitted. + |