summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Kirtland <jek@discorporate.us>2008-03-18 00:25:55 +0000
committerJason Kirtland <jek@discorporate.us>2008-03-18 00:25:55 +0000
commitc462e42dfd705ed781c9ae0505c0c65a71c8936e (patch)
tree8301c312b765816efa8d6d9c16c182a5e188ffc9
parentad4e42567605e31b820766329f460a38603e05d1 (diff)
downloadsqlalchemy-c462e42dfd705ed781c9ae0505c0c65a71c8936e.tar.gz
- Declarative will complete setup for Columns lacking names, allows
a more DRY syntax. class Foo(Base): __tablename__ = 'foos' id = Column(Integer, primary_key=True)
-rw-r--r--CHANGES7
-rw-r--r--lib/sqlalchemy/ext/declarative.py16
-rw-r--r--test/ext/declarative.py13
3 files changed, 28 insertions, 8 deletions
diff --git a/CHANGES b/CHANGES
index 8cf8e4957..8ef5013e3 100644
--- a/CHANGES
+++ b/CHANGES
@@ -42,6 +42,13 @@ CHANGES
@comparable_using(...), front-ends for synonym and
comparable_property.
+ - Declarative will complete setup for Columns lacking names,
+ allows a more DRY syntax.
+
+ class Foo(Base):
+ __tablename__ = 'foos'
+ id = Column(Integer, primary_key=True)
+
0.4.4
------
- sql
diff --git a/lib/sqlalchemy/ext/declarative.py b/lib/sqlalchemy/ext/declarative.py
index 43cdad1cc..333b1eaa4 100644
--- a/lib/sqlalchemy/ext/declarative.py
+++ b/lib/sqlalchemy/ext/declarative.py
@@ -157,7 +157,7 @@ class DeclarativeMeta(type):
return type.__init__(cls, classname, bases, dict_)
cls._decl_class_registry[classname] = cls
- our_stuff = {}
+ our_stuff = util.OrderedDict()
for k in dict_:
value = dict_[k]
if (isinstance(value, tuple) and len(value) == 1 and
@@ -180,9 +180,17 @@ class DeclarativeMeta(type):
table_kw = {'autoload': True}
else:
table_kw = {}
- cls.__table__ = table = Table(tablename, cls.metadata, *[
- c for c in our_stuff.values() if isinstance(c, Column)
- ], **table_kw)
+ cols = []
+ for key, c in our_stuff.iteritems():
+ if not isinstance(c, Column):
+ continue
+ if c.key is None:
+ c.key = key
+ if c.name is None:
+ c.name = key
+ cols.append(c)
+ cls.__table__ = table = Table(tablename, cls.metadata,
+ *cols, **table_kw)
else:
table = cls.__table__
diff --git a/test/ext/declarative.py b/test/ext/declarative.py
index d59f88d08..99686dbe7 100644
--- a/test/ext/declarative.py
+++ b/test/ext/declarative.py
@@ -28,12 +28,17 @@ class DeclarativeTest(TestBase):
class Address(Base, Fixture):
__tablename__ = 'addresses'
- id = Column('id', Integer, primary_key=True)
- email = Column('email', String(50))
- user_id = Column('user_id', Integer, ForeignKey('users.id'))
+ id = Column(Integer, primary_key=True)
+ email = Column(String(50), key='_email')
+ user_id = Column('user_id', Integer, ForeignKey('users.id'),
+ key='_user_id')
Base.metadata.create_all()
-
+
+ assert Address.__table__.c['id'].name == 'id'
+ assert Address.__table__.c['_email'].name == 'email'
+ assert Address.__table__.c['_user_id'].name == 'user_id'
+
u1 = User(name='u1', addresses=[
Address(email='one'),
Address(email='two'),