diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2022-04-08 09:48:26 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2022-04-08 09:48:26 -0400 |
| commit | 9b32d9040a7d5716ae3871acd76a598f6c402423 (patch) | |
| tree | 568b2f4bb6bbf958f1a014b1f2cbbbde8e175f11 | |
| parent | f7ebfa6072d65c32c61194b265662c957d3f09dd (diff) | |
| download | sqlalchemy-9b32d9040a7d5716ae3871acd76a598f6c402423.tar.gz | |
update comment re: #2703
Change-Id: Ia78db7601e98acd2562872e0fda639aac99650dd
| -rw-r--r-- | lib/sqlalchemy/util/langhelpers.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/lib/sqlalchemy/util/langhelpers.py b/lib/sqlalchemy/util/langhelpers.py index 9e1194e23..00097fd9e 100644 --- a/lib/sqlalchemy/util/langhelpers.py +++ b/lib/sqlalchemy/util/langhelpers.py @@ -106,10 +106,12 @@ class safe_reraise: with safe_reraise(): sess.rollback() - TODO: is this context manager getting us anything in Python 3? - Not sure of the coroutine issue stated above; we would assume this was - when using eventlet / gevent. not sure if our own greenlet integration - is impacted. + TODO: we should at some point evaluate current behaviors in this regard + based on current greenlet, gevent/eventlet implementations in Python 3, and + also see the degree to which our own asyncio (based on greenlet also) is + impacted by this. .rollback() will cause IO / context switch to occur in + all these scenarios; what happens to the exception context from an + "except:" block if we don't explicitly store it? Original issue was #2703. """ |