summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2019-08-30 13:11:05 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2019-08-30 13:11:05 -0400
commit2df613243de33aaa202b3ac458304b8ab403e9e7 (patch)
tree08c352338141c7d00efabe449a193ae2c161089c
parentf499671ccc30cd42d6e3beb6ddec60e104bff9c5 (diff)
downloadsqlalchemy-2df613243de33aaa202b3ac458304b8ab403e9e7.tar.gz
Don't create enum constraints in enum sortable tests
Fixed unit test regression released in 1.3.8 that would cause failure for Oracle, SQL Server and other non-native ENUM platforms due to new enumeration tests added as part of :ticket:`4285` enum sortability in the unit of work; the enumerations created constraints that were duplicated on name. Fixes: #4285 Change-Id: I34f51e82be9b6bb43b0df8c54bb36822e6eeb73e
-rw-r--r--doc/build/changelog/unreleased_13/4285.rst9
-rw-r--r--test/orm/test_unitofwork.py18
2 files changed, 24 insertions, 3 deletions
diff --git a/doc/build/changelog/unreleased_13/4285.rst b/doc/build/changelog/unreleased_13/4285.rst
new file mode 100644
index 000000000..082d3e95e
--- /dev/null
+++ b/doc/build/changelog/unreleased_13/4285.rst
@@ -0,0 +1,9 @@
+.. change::
+ :tags: bug, tests
+ :tickets: 4285
+
+ Fixed unit test regression released in 1.3.8 that would cause failure for
+ Oracle, SQL Server and other non-native ENUM platforms due to new
+ enumeration tests added as part of :ticket:`4285` enum sortability in the
+ unit of work; the enumerations created constraints that were duplicated on
+ name.
diff --git a/test/orm/test_unitofwork.py b/test/orm/test_unitofwork.py
index 6185c4a51..f5cc4836f 100644
--- a/test/orm/test_unitofwork.py
+++ b/test/orm/test_unitofwork.py
@@ -3407,7 +3407,11 @@ class EnsurePKSortableTest(fixtures.MappedTest):
Table(
"t1",
metadata,
- Column("id", Enum(cls.MySortableEnum), primary_key=True),
+ Column(
+ "id",
+ Enum(cls.MySortableEnum, create_constraint=False),
+ primary_key=True,
+ ),
Column("data", String(10)),
)
@@ -3416,7 +3420,11 @@ class EnsurePKSortableTest(fixtures.MappedTest):
metadata,
Column(
"id",
- Enum(cls.MyNotSortableEnum, sort_key_function=None),
+ Enum(
+ cls.MyNotSortableEnum,
+ sort_key_function=None,
+ create_constraint=False,
+ ),
primary_key=True,
),
Column("data", String(10)),
@@ -3425,7 +3433,11 @@ class EnsurePKSortableTest(fixtures.MappedTest):
Table(
"t3",
metadata,
- Column("id", Enum(cls.MyNotSortableEnum), primary_key=True),
+ Column(
+ "id",
+ Enum(cls.MyNotSortableEnum, create_constraint=False),
+ primary_key=True,
+ ),
Column("value", Integer),
)