diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-01-14 16:38:14 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-01-14 16:38:14 -0500 |
| commit | e8cddcf723bbfe8e66b302e2b8b7801b38640c93 (patch) | |
| tree | 8635d7f697d8007f0f861d4cff028786253d625e /.github/pull_request_template.md | |
| parent | 4db74e2a8834080679d386a82a7557c570a6259b (diff) | |
| download | sqlalchemy-e8cddcf723bbfe8e66b302e2b8b7801b38640c93.tar.gz | |
another change to the PR template
Change-Id: I29b0f60d3ec32249333edaeb6550147bd740d893
Diffstat (limited to '.github/pull_request_template.md')
| -rw-r--r-- | .github/pull_request_template.md | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3d33e9f5f..81cd523e5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,16 @@ -*** **CHECKLIST FOR PULL REQUESTS!!!** *** +<!-- Provide a general summary of your proposed changes in the Title field above --> -This change is: +### Description +<!-- Describe your changes in detail --> + +### Checklist +<!-- go over following points. check them with an `x` if they do apply, +(they turn into clickable checkboxes once the PR is submitted, so no need +to do everything at once) + +--> + +This pull request is: - [ ] A documentation / typographical error fix - Good to go, no issue or tests are needed @@ -24,8 +34,8 @@ This change is: - [ ] I don't know how to write the tests. in which case please GET HELP FROM THE MAINTAINERS on the above mentioned issue how tests for this feature should be structured. -Note that **we do not accept one-liner code fix pull requests with no tests**. Code that is not +<!-- Note that **we do not accept one-liner code fix pull requests with no tests**. Code that is not tested is itself **a bug**. We will help you fix any problem you have, as long as you produce -[issue reports](https://github.com/sqlalchemy/sqlalchemy/issues) that include code samples, stack traces, and most preferably complete standalone test cases. +[issue reports](https://github.com/sqlalchemy/sqlalchemy/issues) that include code samples, stack traces, and most preferably complete standalone test cases. --> **Have a nice day!** |