diff options
author | Jordan Cook <jordan.cook.git@proton.me> | 2023-05-08 11:23:22 -0500 |
---|---|---|
committer | Jordan Cook <jordan.cook.git@proton.me> | 2023-05-08 11:32:25 -0500 |
commit | 7a0aa6de6bb9d912554bac6cafef2d2ff7c757b6 (patch) | |
tree | 70b96898114b73698dc3cdc4639f215acd07fce1 /tests/unit | |
parent | 83f7bc77e4daeab70e19e29a1ed1ba4bcabff9e1 (diff) | |
download | requests-cache-7a0aa6de6bb9d912554bac6cafef2d2ff7c757b6.tar.gz |
Enable bugbear extension and fix warnings
Diffstat (limited to 'tests/unit')
-rw-r--r-- | tests/unit/models/test_response.py | 6 | ||||
-rw-r--r-- | tests/unit/test_patcher.py | 4 | ||||
-rw-r--r-- | tests/unit/test_session.py | 8 |
3 files changed, 9 insertions, 9 deletions
diff --git a/tests/unit/models/test_response.py b/tests/unit/models/test_response.py index d7f40b9..71517ce 100644 --- a/tests/unit/models/test_response.py +++ b/tests/unit/models/test_response.py @@ -29,7 +29,7 @@ def test_history(mock_session): original_response.history = [mock_session.get(MOCKED_URL)] * 3 response = CachedResponse.from_response(original_response) assert len(response.history) == 3 - assert all([isinstance(r, CachedResponse) for r in response.history]) + assert all(isinstance(r, CachedResponse) for r in response.history) @pytest.mark.parametrize( @@ -118,7 +118,7 @@ def test_str(mock_session): response = CachedResponse.from_response(mock_session.get(MOCKED_URL)) response._content = b'1010' expected_values = ['GET', MOCKED_URL, 200, '4 bytes', 'created', 'expires', 'fresh'] - assert all([str(v) in str(response) for v in expected_values]) + assert all(str(v) in str(response) for v in expected_values) def test_repr(mock_session): @@ -127,7 +127,7 @@ def test_repr(mock_session): expected_values = ['GET', MOCKED_URL, 200, 'ISO-8859-1', response.headers] print(repr(response)) assert repr(response).startswith('CachedResponse(') and repr(response).endswith(')') - assert all([str(v) in repr(response) for v in expected_values]) + assert all(str(v) in repr(response) for v in expected_values) @pytest.mark.parametrize( diff --git a/tests/unit/test_patcher.py b/tests/unit/test_patcher.py index 8977271..422f9a0 100644 --- a/tests/unit/test_patcher.py +++ b/tests/unit/test_patcher.py @@ -57,7 +57,7 @@ def test_clear__not_installed(mock_clear): @patch.object(CachedSession, 'request') def test_disabled(cached_request, original_request, installed_session): with requests_cache.disabled(): - for i in range(3): + for _ in range(3): requests.get('some_url') assert cached_request.call_count == 0 assert original_request.call_count == 3 @@ -67,7 +67,7 @@ def test_disabled(cached_request, original_request, installed_session): @patch.object(CachedSession, 'request') def test_enabled(cached_request, original_request, tempfile_path): with requests_cache.enabled(tempfile_path): - for i in range(3): + for _ in range(3): requests.get('some_url') assert cached_request.call_count == 3 assert original_request.call_count == 0 diff --git a/tests/unit/test_session.py b/tests/unit/test_session.py index 0c5b736..895702b 100644 --- a/tests/unit/test_session.py +++ b/tests/unit/test_session.py @@ -439,7 +439,7 @@ def test_stale_if_error__max_stale(mock_session): mock_session.settings.stale_if_error = timedelta(seconds=15) mock_session.settings.expire_after = datetime.utcnow() - timedelta(seconds=10) mock_session.settings.allowable_codes = (200,) - mock_session.get(MOCKED_URL_200_404).from_cache + mock_session.get(MOCKED_URL_200_404) response = mock_session.get(MOCKED_URL_200_404) assert response.from_cache is True @@ -459,7 +459,7 @@ def test_old_data_on_error(): def test_cache_disabled(mock_session): mock_session.get(MOCKED_URL) with mock_session.cache_disabled(): - for i in range(2): + for _ in range(2): assert mock_session.get(MOCKED_URL).from_cache is False assert mock_session.get(MOCKED_URL).from_cache is True @@ -469,7 +469,7 @@ def test_cache_disabled__nested(mock_session): with mock_session.cache_disabled(): mock_session.get(MOCKED_URL) with mock_session.cache_disabled(): - for i in range(2): + for _ in range(2): assert mock_session.get(MOCKED_URL).from_cache is False assert mock_session.get(MOCKED_URL).from_cache is True @@ -616,7 +616,7 @@ def test_hooks(mock_session): assert r.from_cache is True return r - for i in range(5): + for _ in range(5): mock_session.get(MOCKED_URL, hooks={hook: hook_func}) assert state[hook] == 5 |