QPID-5981: Improve look and feel of 'Add binding' dialog in web management console:

           make 'Binding Argument' grid height auto-resizable
           make 'Binding key' form field required
           replace 'Binding Arguments' button captions Add/Delete with +/-
	   remove empty option for x-qpid-no-local

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1617238 13f79535-47bb-0310-9956-ffa450edef68

2 files changed, 16 insertions, 6 deletions

diff --git a/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html b/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html
index b57e3a1a24..a07419977b 100644
--- a/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html
+++ b/qpid/java/broker-plugins/management-http/src/main/java/resources/addBinding.html
@@ -38,6 +38,7 @@
                            data-dojo-props="
                               name: 'name',
                               placeHolder: 'Binding Key',
+                              required: true,
                               missingMessage: 'A binding key must be supplied',
                               title: 'Enter binding key'" />
                 </div>
@@ -49,8 +50,8 @@
                     <div class="editNoteBanner">NOTE: Only arguments with name and value will be submitted. To edit, please, click on a grid cell.</div>
                     <div id="formAddbinding.bindingArguments"></div>
                     <div>
-                        <button data-dojo-type="dijit/form/Button" id="formAddbinding.addArgumentButton" type="button">Add</button>
-                        <button data-dojo-type="dijit/form/Button" id="formAddbinding.deleteArgumentButton" type="button">Delete</button>
+                        <button data-dojo-type="dijit/form/Button" id="formAddbinding.addArgumentButton" type="button" data-dojo-props="title:'Add new binding argument'">+</button>
+                        <button data-dojo-type="dijit/form/Button" id="formAddbinding.deleteArgumentButton" type="button" data-dojo-props="title:'Remove selected binding argument(s)'">-</button>
                     </div>
                 </fieldset>
             </div>
diff --git a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js
index deda3f35d5..8e70b78446 100644
--- a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js
+++ b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addBinding.js
@@ -14,7 +14,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-define(["dojo/_base/xhr",
+define(["dojo/_base/connect",
+        "dojo/_base/xhr",
         "dojo/dom",
         "dojo/dom-construct",
         "dojo/_base/window",
@@ -43,11 +44,10 @@ define(["dojo/_base/xhr",
         "dojox/grid/EnhancedGrid",
         "dojo/data/ObjectStore",
         "dojo/domReady!"],
-    function (xhr, dom, construct, win, registry, parser, array, event, json, lang, declare, Memory, FilteringSelect) {
+    function (connect, xhr, dom, construct, win, registry, parser, array, event, json, lang, declare, Memory, FilteringSelect) {
 
         var noLocalValues = new Memory({
             data: [
-                {name:"", id:null},
                 {name:"true", id:true},
                 {name:"false", id:false}
             ]
@@ -243,7 +243,7 @@ define(["dojo/_base/xhr",
                                     store: objectStore,
                                     singleClickEdit: true,
                                     structure: layout,
-                                    height: "150px",
+                                    autoHeight: true,
                                     plugins: {indirectSelection: true}
                                     }, argumentsGridNode);
                             grid.startup();
@@ -253,6 +253,15 @@ define(["dojo/_base/xhr",
                             var addArgumentButton = registry.byId("formAddbinding.addArgumentButton");
                             var deleteArgumentButton = registry.byId("formAddbinding.deleteArgumentButton");
 
+                            var toggleGridButtons =  function(index)
+                            {
+                                var data = grid.selection.getSelected();
+                                deleteArgumentButton.set("disabled", !data || data.length==0);
+                            };
+                            connect.connect(grid.selection, 'onSelected', toggleGridButtons);
+                            connect.connect(grid.selection, 'onDeselected', toggleGridButtons);
+                            deleteArgumentButton.set("disabled", true);
+
                             addArgumentButton.on("click",
                                 function(event)
                                 {