QPID-3659 The previous if statement for processing boolean props looks a bit convoluted. Changed it to a more simple and easily readable statement.

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1221557 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 12 insertions, 8 deletions

diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
index d6589bacdf..b343820d80 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
@@ -271,14 +271,18 @@ public class AMQBrokerDetails implements BrokerDetails
     {
     	if (_options.containsKey(propName))
     	{
-    		if (defaultValue)
-    		{
-    			return !_options.get(propName).equalsIgnoreCase("false");
-    		}
-    		else
-    		{
-    			return Boolean.parseBoolean(_options.get(propName));
-    		}
+            if (_options.get(propName).equalsIgnoreCase("false"))
+            {
+                return false;
+            }
+            else if (_options.get(propName).equalsIgnoreCase("true"))
+            {
+                return true;
+            }
+            else
+            {
+               return defaultValue;
+            }
     	}
     	else
     	{