QPID-4312: reduce visibility and narrow argument type for new check methods, add some unit testing of config and cleanup IDT systest a little

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1442602 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 6 insertions, 5 deletions

diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
index 20eaca44ae..308c63923e 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
@@ -590,20 +590,21 @@ public abstract class BasicMessageProducer extends Closeable implements org.apac
 
     }
 
-    void checkValidQueue() throws JMSException
+    private void checkValidQueue() throws JMSException
     {
         if(_destination instanceof AMQQueue)
         {
-            checkValidQueue(_destination);
+            checkValidQueue((AMQQueue) _destination);
         }
     }
-    void checkValidQueue(AMQDestination destination) throws JMSException
+
+    private void checkValidQueue(AMQQueue destination) throws JMSException
     {
         if (!destination.isCheckedForQueueBinding() && validateQueueOnSend())
         {
             if (getSession().isStrictAMQP())
             {
-                getLogger().warn("AMQP does not support destination validation before publish, ");
+                getLogger().warn("AMQP does not support destination validation before publish");
                 destination.setCheckedForQueueBinding(true);
             }
             else
@@ -615,7 +616,7 @@ public abstract class BasicMessageProducer extends Closeable implements org.apac
                 else
                 {
                     throw new InvalidDestinationException("Queue: " + destination.getName()
-                        + " is not a valid destination (no bindings on server");
+                        + " is not a valid destination (no binding on server)");
                 }
             }
         }