diff options
| author | Michael Goulish <mgoulish@apache.org> | 2011-10-13 21:50:56 +0000 |
|---|---|---|
| committer | Michael Goulish <mgoulish@apache.org> | 2011-10-13 21:50:56 +0000 |
| commit | 0d410c6aa9ad565f93221691123a5b3c45b42ec3 (patch) | |
| tree | a894c4cb0586f2b38d10596d6a1fe3b28d640050 /qpid/cpp/src/tests/sasl.mk | |
| parent | d9ef71a5813ea9f54928392997e48e5205b4c4f6 (diff) | |
| download | qpid-python-0d410c6aa9ad565f93221691123a5b3c45b42ec3.tar.gz | |
QPID-3528
sasl_set_path() does no check on the given directory, so when you get bad behavior
later it can be hard to track down. Especially bad is its policy of defaulting to
an alternate standard location if yours fails. That's a potential security bug.
So this patch checks that your dir exists, and is readable, before calling
sasl_set_path(). Either you get the sasl config dir you were expecting,
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1183121 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src/tests/sasl.mk')
| -rw-r--r-- | qpid/cpp/src/tests/sasl.mk | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/qpid/cpp/src/tests/sasl.mk b/qpid/cpp/src/tests/sasl.mk index 20eaa7c7a5..69b24c3f8a 100644 --- a/qpid/cpp/src/tests/sasl.mk +++ b/qpid/cpp/src/tests/sasl.mk @@ -30,7 +30,7 @@ check_PROGRAMS+=sasl_version sasl_version_SOURCES=sasl_version.cpp sasl_version_LDADD=$(lib_client) -TESTS += run_cluster_authentication_test sasl_fed sasl_fed_ex_dynamic sasl_fed_ex_link sasl_fed_ex_queue sasl_fed_ex_route sasl_fed_ex_route_cluster sasl_fed_ex_link_cluster sasl_fed_ex_queue_cluster sasl_fed_ex_dynamic_cluster +TESTS += run_cluster_authentication_test sasl_fed sasl_fed_ex_dynamic sasl_fed_ex_link sasl_fed_ex_queue sasl_fed_ex_route sasl_fed_ex_route_cluster sasl_fed_ex_link_cluster sasl_fed_ex_queue_cluster sasl_fed_ex_dynamic_cluster sasl_no_dir LONG_TESTS += run_cluster_authentication_soak EXTRA_DIST += run_cluster_authentication_test \ sasl_fed \ @@ -43,7 +43,8 @@ EXTRA_DIST += run_cluster_authentication_test \ sasl_fed_ex_dynamic_cluster \ sasl_fed_ex_link_cluster \ sasl_fed_ex_queue_cluster \ - sasl_fed_ex_route_cluster + sasl_fed_ex_route_cluster \ + sasl_no_dir endif # HAVE_SASL |