diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2014-07-31 17:10:17 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2014-07-31 17:10:17 +0000 |
| commit | 2dca80f0ebda2def3773fb13af87f0eb6d5051da (patch) | |
| tree | 6f2427861b9c48d0965e21e0814814d5cdb134da | |
| parent | dc9d1fb1ca2a6dd0d3985ba4e17cb73fcfa2e3e4 (diff) | |
| download | qpid-python-2dca80f0ebda2def3773fb13af87f0eb6d5051da.tar.gz | |
QPID-5937 : Address comments from ~k-wall
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1614938 13f79535-47bb-0310-9956-ffa450edef68
2 files changed, 2 insertions, 15 deletions
diff --git a/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java b/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java index 2ff6d80427..ac5c75f80f 100644 --- a/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java +++ b/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObject.java @@ -79,7 +79,7 @@ public interface ConfiguredObject<X extends ConfiguredObject<X>> <T> T getContextValue(Class<T> clazz, String propertyName); - Set<String> getContextKeys(final boolean includeSystem); + Set<String> getContextKeys(final boolean excludeSystem); @DerivedAttribute( persist = true ) String getLastUpdatedBy(); diff --git a/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java b/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java index 8df234d24d..57b3df8050 100644 --- a/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java +++ b/qpid/java/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java @@ -621,20 +621,7 @@ public class RestServlet extends AbstractServlet private boolean getBooleanParameterFromRequest(HttpServletRequest request, final String paramName) { - boolean value = false; - final String stringValue = request.getParameter(paramName); - if(stringValue!=null) - { - try - { - value = Boolean.parseBoolean(stringValue); - } - catch (NumberFormatException e) - { - LOGGER.warn("Could not parse " + stringValue + " as integer"); - } - } - return value; + return Boolean.parseBoolean(request.getParameter(paramName)); } } |