5 files changed, 198 insertions, 0 deletions
diff --git a/test/functional/string_formatting.py b/test/functional/string_formatting.py
new file mode 100644
index 0000000..594c870
--- /dev/null
+++ b/test/functional/string_formatting.py
@@ -0,0 +1,121 @@
+"""test for Python 3 string formatting error
+"""
+# pylint: disable=too-few-public-methods, import-error, unused-argument, star-args, line-too-long
+import os
+from missing import Missing
+
+__revision__ = 1
+
+class Custom(object):
+    """ Has a __getattr__ """
+    def __getattr__(self):
+        return self
+
+class Test(object):
+    """ test format attribute access """
+    custom = Custom()
+    ids = [1, 2, 3, [4, 5, 6]]
+
+class Getitem(object):
+    """ test custom getitem for lookup access """
+    def __getitem__(self, index):
+        return 42
+
+class ReturnYes(object):
+    """ can't be properly infered """
+    missing = Missing()
+
+def log(message, message_type="error"):
+    """ Test """
+    return message
+
+def print_good():
+    """ Good format strings """
+    "{0} {1}".format(1, 2)
+    "{0!r:20}".format("Hello")
+    "{!r:20}".format("Hello")
+    "{a!r:20}".format(a="Hello")
+    "{pid}".format(pid=os.getpid())
+    str("{}").format(2)
+    "{0.missing.length}".format(ReturnYes())
+    "{1.missing.length}".format(ReturnYes())
+    "{a.ids[3][1]}".format(a=Test())
+    "{a[0][0]}".format(a=[[1]])
+    "{[0][0]}".format({0: {0: 1}})
+    "{a.test}".format(a=Custom())
+    "{a.__len__}".format(a=[])
+    "{a.ids.__len__}".format(a=Test())
+    "{a[0]}".format(a=Getitem())
+    "{a[0][0]}".format(a=[Getitem()])
+    "{[0][0]}".format(["test"])
+    # these are skipped
+    "{0} {1}".format(*[1, 2])
+    "{a} {b}".format(**{'a': 1, 'b': 2})
+    "{a}".format(a=Missing())
+
+def pprint_bad():
+    """Test string format """
+    "{{}}".format(1) # [too-many-format-args]
+    "{} {".format() # [bad-format-string]
+    "{} }".format() # [bad-format-string]
+    "{0} {}".format(1, 2) # [format-combined-specification]
+    # +1: [missing-format-argument-key, unused-format-string-argument]
+    "{a} {b}".format(a=1, c=2)
+    "{} {a}".format(1, 2) # [missing-format-argument-key]
+    "{} {}".format(1) # [too-few-format-args]
+    "{} {}".format(1, 2, 3) # [too-many-format-args]
+    # +1: [missing-format-argument-key,missing-format-argument-key,missing-format-argument-key]
+    "{a} {b} {c}".format()
+    "{} {}".format(a=1, b=2) # [too-few-format-args]
+    # +1: [missing-format-argument-key, missing-format-argument-key]
+    "{a} {b}".format(1, 2)
+    "{0} {1} {a}".format(1, 2, 3) # [missing-format-argument-key]
+    # +1: [missing-format-attribute]
+    "{a.ids.__len__.length}".format(a=Test())
+    "{a.ids[3][400]}".format(a=Test()) # [invalid-format-index]
+    "{a.ids[3]['string']}".format(a=Test()) # [invalid-format-index]
+    "{[0][1]}".format(["a"]) # [invalid-format-index]
+    "{[0][0]}".format(((1, ))) # [invalid-format-index]
+    # +1: [missing-format-argument-key, unused-format-string-argument]
+    "{b[0]}".format(a=23)
+    "{a[0]}".format(a=object) # [invalid-format-index]
+    log("{}".format(2, "info")) # [too-many-format-args]
+    "{0.missing}".format(2) # [missing-format-attribute]
+    "{0} {1} {2}".format(1, 2) # [too-few-format-args]
+    "{0} {1}".format(1, 2, 3) # [too-many-format-args]
+    "{0} {a}".format(a=4) # [too-few-format-args]
+    "{[0]} {}".format([4]) # [too-few-format-args]
+    "{[0]} {}".format([4], 5, 6) # [too-many-format-args]
+
+def good_issue288(*args, **kwargs):
+    """ Test that using kwargs does not emit a false
+    positive.
+    """
+    'Hello John Doe {0[0]}'.format(args)
+    'Hello {0[name]}'.format(kwargs)
+
+def good_issue287():
+    """ Test that the string format checker skips
+    format nodes which don't have a string as a parent
+    (but a subscript, name etc).
+    """
+    name = 'qwerty'
+    ret = {'comment': ''}
+    ret['comment'] = 'MySQL grant {0} is set to be revoked'
+    ret['comment'] = ret['comment'].format(name)
+    return ret, name
+
+def nested_issue294():
+    """ Test nested format fields. """
+    '{0:>{1}}'.format(42, 24)
+    '{0:{a[1]}} {a}'.format(1, a=[1, 2])
+    '{:>{}}'.format(42, 24)
+    '{0:>{1}}'.format(42) # [too-few-format-args]
+    '{0:>{1}}'.format(42, 24, 54) # [too-many-format-args]
+    '{0:{a[1]}}'.format(1) # [missing-format-argument-key]
+    '{0:{a.x}}'.format(1, a=2) # [missing-format-attribute]
+
+def issue310():
+    """ Test a regression using duplicate manual position arguments. """
+    '{0} {1} {0}'.format(1, 2)
+    '{0} {1} {0}'.format(1) # [too-few-format-args]
diff --git a/test/functional/string_formatting.txt b/test/functional/string_formatting.txt
new file mode 100644
index 0000000..5f27835
--- /dev/null
+++ b/test/functional/string_formatting.txt
@@ -0,0 +1,36 @@
+too-many-format-args:58:pprint_bad:Too many arguments for format string
+bad-format-string:59:pprint_bad:Invalid format string
+bad-format-string:60:pprint_bad:Invalid format string
+format-combined-specification:61:pprint_bad:Format string contains both automatic field numbering and manual field specification
+missing-format-argument-key:63:pprint_bad:Missing keyword argument 'b' for format string
+unused-format-string-argument:63:pprint_bad:Unused format argument 'c'
+missing-format-argument-key:64:pprint_bad:Missing keyword argument 'a' for format string
+too-few-format-args:65:pprint_bad:Not enough arguments for format string
+too-many-format-args:66:pprint_bad:Too many arguments for format string
+missing-format-argument-key:68:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-argument-key:68:pprint_bad:Missing keyword argument 'b' for format string
+missing-format-argument-key:68:pprint_bad:Missing keyword argument 'c' for format string
+too-few-format-args:69:pprint_bad:Not enough arguments for format string
+missing-format-argument-key:71:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-argument-key:71:pprint_bad:Missing keyword argument 'b' for format string
+missing-format-argument-key:72:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-attribute:74:pprint_bad:Missing format attribute 'length' in format specifier 'a.ids.__len__.length'
+invalid-format-index:75:pprint_bad:Using invalid lookup key 400 in format specifier 'a.ids[3][400]'
+invalid-format-index:76:pprint_bad:Using invalid lookup key "'string'" in format specifier 'a.ids[3]["\'string\'"]'
+invalid-format-index:77:pprint_bad:Using invalid lookup key 1 in format specifier '0[0][1]'
+invalid-format-index:78:pprint_bad:Using invalid lookup key 0 in format specifier '0[0][0]'
+missing-format-argument-key:80:pprint_bad:Missing keyword argument 'b' for format string
+unused-format-string-argument:80:pprint_bad:Unused format argument 'a'
+invalid-format-index:81:pprint_bad:Using invalid lookup key 0 in format specifier 'a[0]'
+too-many-format-args:82:pprint_bad:Too many arguments for format string
+missing-format-attribute:83:pprint_bad:Missing format attribute 'missing' in format specifier '0.missing'
+too-few-format-args:84:pprint_bad:Not enough arguments for format string
+too-many-format-args:85:pprint_bad:Too many arguments for format string
+too-few-format-args:86:pprint_bad:Not enough arguments for format string
+too-few-format-args:87:pprint_bad:Not enough arguments for format string
+too-many-format-args:88:pprint_bad:Too many arguments for format string
+too-few-format-args:113:nested_issue294:Not enough arguments for format string
+too-many-format-args:114:nested_issue294:Too many arguments for format string
+missing-format-argument-key:115:nested_issue294:Missing keyword argument 'a' for format string
+missing-format-attribute:116:nested_issue294:Missing format attribute 'x' in format specifier 'a.x'
+too-few-format-args:121:issue310:Not enough arguments for format string
diff --git a/test/functional/string_formatting_py27.py b/test/functional/string_formatting_py27.py
new file mode 100644
index 0000000..d6aeae7
--- /dev/null
+++ b/test/functional/string_formatting_py27.py
@@ -0,0 +1,23 @@
+"""test for Python 2 string formatting error
+"""
+from __future__ import unicode_literals
+# pylint: disable=line-too-long
+__revision__ = 1
+
+def pprint_bad():
+    """Test string format """
+    "{{}}".format(1) # [too-many-format-args]
+    "{} {".format() # [bad-format-string]
+    "{} }".format() # [bad-format-string]
+    "{0} {}".format(1, 2) # [format-combined-specification]
+    # +1: [missing-format-argument-key, unused-format-string-argument]
+    "{a} {b}".format(a=1, c=2)
+    "{} {a}".format(1, 2) # [missing-format-argument-key]
+    "{} {}".format(1) # [too-few-format-args]
+    "{} {}".format(1, 2, 3) # [too-many-format-args]
+    # +1: [missing-format-argument-key,missing-format-argument-key,missing-format-argument-key]
+    "{a} {b} {c}".format()
+    "{} {}".format(a=1, b=2) # [too-few-format-args]
+    # +1: [missing-format-argument-key, missing-format-argument-key]
+    "{a} {b}".format(1, 2)
+
diff --git a/test/functional/string_formatting_py27.rc b/test/functional/string_formatting_py27.rc
new file mode 100644
index 0000000..80170b7
--- /dev/null
+++ b/test/functional/string_formatting_py27.rc
@@ -0,0 +1,3 @@
+[testoptions]
+min_pyver=2.7
+max_pyver=3.0
+\ No newline at end of file
diff --git a/test/functional/string_formatting_py27.txt b/test/functional/string_formatting_py27.txt
new file mode 100644
index 0000000..47f21de
--- /dev/null
+++ b/test/functional/string_formatting_py27.txt
@@ -0,0 +1,15 @@
+too-many-format-args:9:pprint_bad:Too many arguments for format string
+bad-format-string:10:pprint_bad:Invalid format string
+bad-format-string:11:pprint_bad:Invalid format string
+format-combined-specification:12:pprint_bad:Format string contains both automatic field numbering and manual field specification
+missing-format-argument-key:14:pprint_bad:Missing keyword argument u'b' for format string
+unused-format-string-argument:14:pprint_bad:Unused format argument 'c'
+missing-format-argument-key:15:pprint_bad:Missing keyword argument u'a' for format string
+too-few-format-args:16:pprint_bad:Not enough arguments for format string
+too-many-format-args:17:pprint_bad:Too many arguments for format string
+missing-format-argument-key:19:pprint_bad:Missing keyword argument u'a' for format string
+missing-format-argument-key:19:pprint_bad:Missing keyword argument u'b' for format string
+missing-format-argument-key:19:pprint_bad:Missing keyword argument u'c' for format string
+too-few-format-args:20:pprint_bad:Not enough arguments for format string
+missing-format-argument-key:22:pprint_bad:Missing keyword argument u'a' for format string
+missing-format-argument-key:22:pprint_bad:Missing keyword argument u'b' for format string