diff options
| author | Jonathan Huot <JonathanHuot@users.noreply.github.com> | 2018-09-07 23:27:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-09-07 23:27:09 +0200 |
| commit | 7ae5ed1a366f76f0edaf76c2429a81a6cb794d40 (patch) | |
| tree | 0f4e404c8441a42c9c00d31c382763b50918c4cc /docs/contributing.rst | |
| parent | f38dd4ba5da15756ea6c4c46c775983d55f6f6b9 (diff) | |
| parent | 36e7f50049f3333db72ebcb82677b465ec09f84b (diff) | |
| download | oauthlib-fix-oidc-tests.tar.gz | |
Merge branch 'master' into fix-oidc-testsfix-oidc-tests
Diffstat (limited to 'docs/contributing.rst')
| -rw-r--r-- | docs/contributing.rst | 42 |
1 files changed, 39 insertions, 3 deletions
diff --git a/docs/contributing.rst b/docs/contributing.rst index 601c567..cbdb519 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -30,12 +30,37 @@ personal label matching your GitHub ID will be assigned to that issue. Feel free to propose issues that aren't described! +oauthlib community rules +======================== + +oauthlib is a community of developers which adheres to a very simple set of +rules. + +Code of Conduct +--------------- +This project adheres to a `Code of Conduct`_ based on Django. As a community +member you have to read and agree with it. + +For more information please contact us and/or visit the original +`Django Code of Conduct`_ homepage. + +.. _`Code of Conduct`: https://github.com/oauthlib/oauthlib/blob/master/CODE_OF_CONDUCT.md +.. _`Django Code of Conduct`: https://www.djangoproject.com/conduct/ + +Code of Merit +------------- +Please read the community's `Code of Merit`_. Every contributor will know the +real purpose of their contributions to this project. + +.. _`Code of Merit`: http://code-of-merit.org/ + + Setting up topic branches and generating pull requests ====================================================== While it's handy to provide useful code snippets in an issue, it is better for you as a developer to submit pull requests. By submitting pull request your -contribution to OpenComparison will be recorded by Github. +contribution to OAuthlib will be recorded by Github. In git it is best to isolate each topic or feature into a "topic branch". While individual commits allow you control over how small individual changes are made @@ -127,7 +152,7 @@ request that fails this test suite will be **rejected**. Testing multiple versions of Python ----------------------------------- -OAuthLib supports Python 2.6, 2.7, 3.2, 3.3 and experimentally PyPy. Testing +OAuthLib supports Python 2.7, 3.4, 3.5, 3.6 and PyPy. Testing all versions conveniently can be done using `Tox`_. .. sourcecode:: bash @@ -150,6 +175,17 @@ version. For Ubuntu you can easily install all after adding one ppa. .. _`Tox`: https://tox.readthedocs.io/en/latest/install.html .. _`virtualenv`: https://virtualenv.pypa.io/en/latest/installation/ +Test upstream applications +----------------------------------- + +Remember, OAuthLib is used by several 3rd party projects. If you think you +submit a breaking change, confirm that other projects builds are not affected. + +.. sourcecode:: bash + + $ make + + If you add code you need to add tests! -------------------------------------- @@ -207,7 +243,7 @@ How pull requests are checked, tested, and done First we pull the code into a local branch:: - git remote add <submitter-github-name> git@github.com:<submitter-github-name>/opencomparison.git + git remote add <submitter-github-name> git@github.com:<submitter-github-name>/oauthlib.git git fetch <submitter-github-name> git checkout -b <branch-name> <submitter-github-name>/<branch-name> |
