diff options
| -rw-r--r-- | kombu/connection.py | 2 | ||||
| -rw-r--r-- | t/unit/test_connection.py | 13 |
2 files changed, 14 insertions, 1 deletions
diff --git a/kombu/connection.py b/kombu/connection.py index 03b3161d..e2dd69b6 100644 --- a/kombu/connection.py +++ b/kombu/connection.py @@ -625,7 +625,7 @@ class Connection: transport_cls, transport_cls) D = self.transport.default_connection_params - if not self.hostname: + if not self.hostname and D.get('hostname'): logger.warning( "No hostname was supplied. " f"Reverting to default '{D.get('hostname')}'") diff --git a/t/unit/test_connection.py b/t/unit/test_connection.py index b65416e8..17ea7b34 100644 --- a/t/unit/test_connection.py +++ b/t/unit/test_connection.py @@ -99,6 +99,19 @@ class test_connection_utils: # see Appendix A of http://www.rabbitmq.com/uri-spec.html self.assert_info(Connection(url), **expected) + @pytest.mark.parametrize('url,expected', [ + ('sqs://user:pass@', + {'userid': None, 'password': None, 'hostname': None, + 'port': None, 'virtual_host': '/'}), + ('sqs://', + {'userid': None, 'password': None, 'hostname': None, + 'port': None, 'virtual_host': '/'}), + ]) + def test_sqs_example_urls(self, url, expected, caplog): + pytest.importorskip('boto3') + self.assert_info(Connection('sqs://'), **expected) + assert not caplog.records + @pytest.mark.skip('TODO: urllib cannot parse ipv6 urls') def test_url_IPV6(self): self.assert_info( |