diff options
author | Joshua Harlow <harlowja@gmail.com> | 2015-06-17 09:53:33 -0700 |
---|---|---|
committer | Joshua Harlow <harlowja@gmail.com> | 2015-06-17 09:53:33 -0700 |
commit | dbca7ad0851e750915227709f4e3a8e75678a5d9 (patch) | |
tree | a141bb3eb7ece5f1bafc49a8829924126eeda6a9 | |
parent | 7b89bf1c1b429b2fdb5969fc34951694ddc9f7df (diff) | |
parent | 591df77dab64469f3a11a9fb53ecafbcfa789963 (diff) | |
download | kazoo-dbca7ad0851e750915227709f4e3a8e75678a5d9.tar.gz |
Merge pull request #340 from rgs1/fix-nameerror-basestring
Fix NameError with basestring (in py3k)
-rw-r--r-- | CHANGES.rst | 13 | ||||
-rw-r--r-- | kazoo/client.py | 6 |
2 files changed, 16 insertions, 3 deletions
diff --git a/CHANGES.rst b/CHANGES.rst index 039c213..ab85b3e 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,19 @@ Changelog ========= +2.2.1 (2015-XX-XX) +----- + +Features +******** + +Bug Handling +************ +- handle NameError with basestring on py3k. + +Documentation +************* + 2.2 (2015-06-15) ---------------- diff --git a/kazoo/client.py b/kazoo/client.py index 7850f4c..27fbe00 100644 --- a/kazoo/client.py +++ b/kazoo/client.py @@ -1404,11 +1404,11 @@ class KazooClient(object): :rtype: :class:`~kazoo.interfaces.IAsyncResult` """ - if joining and not isinstance(joining, basestring): + if joining and not isinstance(joining, string_types): raise TypeError("Invalid type for 'joining' (string expected)") - if leaving and not isinstance(leaving, basestring): + if leaving and not isinstance(leaving, string_types): raise TypeError("Invalid type for 'leaving' (string expected)") - if new_members and not isinstance(new_members, basestring): + if new_members and not isinstance(new_members, string_types): raise TypeError("Invalid type for 'new_members' (string " "expected)") if not isinstance(from_config, int): |