summaryrefslogtreecommitdiff
path: root/kafka
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2014-12-11 16:36:41 -0800
committerDana Powers <dana.powers@rd.io>2014-12-15 12:43:45 -0800
commite3fd29cb37a9d661afcf913dfa2c4552638bb4fd (patch)
tree5ca0d6422846b1780a4a109ed3a71832045bc913 /kafka
parentd27d49fd6b1c02dc764035cb06c3b47bf2a4b7a5 (diff)
downloadkafka-python-e3fd29cb37a9d661afcf913dfa2c4552638bb4fd.tar.gz
Simplify BYTES_CONFIGURATION_KEYS logic, per wizzat review
Diffstat (limited to 'kafka')
-rw-r--r--kafka/consumer/kafka.py3
1 files changed, 1 insertions, 2 deletions
diff --git a/kafka/consumer/kafka.py b/kafka/consumer/kafka.py
index f07bedf..db86bab 100644
--- a/kafka/consumer/kafka.py
+++ b/kafka/consumer/kafka.py
@@ -160,8 +160,7 @@ class KafkaConsumer(object):
# Handle str/bytes conversions
for config_key in BYTES_CONFIGURATION_KEYS:
- if not (self._config[config_key] is None or
- isinstance(self._config[config_key], six.binary_type)):
+ if isinstance(self._config[config_key], six.string_types):
logger.warning("Converting configuration key '%s' to bytes" %
config_key)
self._config[config_key] = self._config[config_key].encode('utf-8')