Cleanup error loggingerrors

  - add error type to all KafkaErrors
  - add args to BrokerResponseError
  - drop description from BrokerResponseError
  - fix bug logging errbacks as callbacks

2 files changed, 12 insertions, 2 deletions

diff --git a/kafka/errors.py b/kafka/errors.py
index df035c4..3de6ff2 100644
--- a/kafka/errors.py
+++ b/kafka/errors.py
@@ -7,6 +7,12 @@ class KafkaError(RuntimeError):
     # whether metadata should be refreshed on error
     invalid_metadata = False
 
+    def __str__(self):
+        if not self.args:
+            return self.__class__.__name__
+        return '{}: {}'.format(self.__class__.__name__,
+                               super(KafkaError, self).__str__())
+
 
 class IllegalStateError(KafkaError):
     pass
@@ -56,7 +62,11 @@ class BrokerResponseError(KafkaError):
     description = None
 
     def __str__(self):
-        return '%s - %s - %s' % (self.__class__.__name__, self.errno, self.description)
+        """Add errno to standard KafkaError str"""
+        return '[Error {}] {}: {}'.format(
+            self.errno,
+            self.__class__.__name__,
+            super(KafkaError, self).__str__()) # pylint: disable=bad-super-call
 
 
 class NoError(BrokerResponseError):
diff --git a/kafka/future.py b/kafka/future.py
index c22755a..a4b7deb 100644
--- a/kafka/future.py
+++ b/kafka/future.py
@@ -55,7 +55,7 @@ class Future(object):
         if args or kwargs:
             f = functools.partial(f, *args, **kwargs)
         if self.is_done and self.exception:
-            self._call_backs('callback', [f], self.exception)
+            self._call_backs('errback', [f], self.exception)
         else:
             self._errbacks.append(f)
         return self