diff options
| author | Sebastian Thiel <byronimo@gmail.com> | 2016-05-24 15:55:40 +0200 |
|---|---|---|
| committer | Sebastian Thiel <byronimo@gmail.com> | 2016-05-24 15:55:40 +0200 |
| commit | 7a8f96cc8a5135a0ece19e600da914dabca7d215 (patch) | |
| tree | b1e67c028e1dce9693ffe4282d42f87bc628cb0a | |
| parent | db44286366a09f1f65986db2a1c8b470fb417068 (diff) | |
| download | gitpython-7a8f96cc8a5135a0ece19e600da914dabca7d215.tar.gz | |
fix(cmd): don't catch progress handler exceptions
Fixes #435
| -rw-r--r-- | doc/source/changes.rst | 6 | ||||
| -rw-r--r-- | git/cmd.py | 7 |
2 files changed, 7 insertions, 6 deletions
diff --git a/doc/source/changes.rst b/doc/source/changes.rst index 51d3954a..8cc9ca0d 100644 --- a/doc/source/changes.rst +++ b/doc/source/changes.rst @@ -2,6 +2,12 @@ Changelog ========= +2.0.3 - Fixes +============= + +* Fix: progress handler exceptions are not caught anymore, which would usually just hide bugs + previously. + 2.0.2 - Fixes ============= @@ -113,12 +113,7 @@ def handle_process_output(process, stdout_handler, stderr_handler, finalizer): def _dispatch_single_line(line, handler): line = line.decode(defenc) if line and handler: - try: - handler(line) - except Exception: - # Keep reading, have to pump the lines empty nontheless - log.error("Line handler exception on line: %s", line, exc_info=True) - # end + handler(line) # end dispatch helper # end single line helper |