From 7a8f96cc8a5135a0ece19e600da914dabca7d215 Mon Sep 17 00:00:00 2001 From: Sebastian Thiel Date: Tue, 24 May 2016 15:55:40 +0200 Subject: fix(cmd): don't catch progress handler exceptions Fixes #435 --- doc/source/changes.rst | 6 ++++++ git/cmd.py | 7 +------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/source/changes.rst b/doc/source/changes.rst index 51d3954a..8cc9ca0d 100644 --- a/doc/source/changes.rst +++ b/doc/source/changes.rst @@ -2,6 +2,12 @@ Changelog ========= +2.0.3 - Fixes +============= + +* Fix: progress handler exceptions are not caught anymore, which would usually just hide bugs + previously. + 2.0.2 - Fixes ============= diff --git a/git/cmd.py b/git/cmd.py index 539482df..8a657dc1 100644 --- a/git/cmd.py +++ b/git/cmd.py @@ -113,12 +113,7 @@ def handle_process_output(process, stdout_handler, stderr_handler, finalizer): def _dispatch_single_line(line, handler): line = line.decode(defenc) if line and handler: - try: - handler(line) - except Exception: - # Keep reading, have to pump the lines empty nontheless - log.error("Line handler exception on line: %s", line, exc_info=True) - # end + handler(line) # end dispatch helper # end single line helper -- cgit v1.2.1