summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2022-05-31 07:46:37 -0700
committerJohn L. Villalovos <john@sodarock.com>2022-05-31 07:46:37 -0700
commit7d26530640eb406479f1604cb64748d278081864 (patch)
treeaf198b756ca6879f0104be2b0857fa1cfee9e694 /tests
parent1f17349826a0516c648db20ae80ac713bab8a160 (diff)
downloadgitlab-7d26530640eb406479f1604cb64748d278081864.tar.gz
chore: move `RequiredOptional` to the `gitlab.types` module
By having `RequiredOptional` in the `gitlab.base` module it makes it difficult with circular imports. Move it to the `gitlab.types` module which has no dependencies on any other gitlab module.
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/mixins/test_mixin_methods.py21
1 files changed, 11 insertions, 10 deletions
diff --git a/tests/unit/mixins/test_mixin_methods.py b/tests/unit/mixins/test_mixin_methods.py
index c0b0a58..3c2454e 100644
--- a/tests/unit/mixins/test_mixin_methods.py
+++ b/tests/unit/mixins/test_mixin_methods.py
@@ -2,6 +2,7 @@ import pytest
import responses
from gitlab import base
+from gitlab import types as gl_types
from gitlab.mixins import (
CreateMixin,
DeleteMixin,
@@ -166,7 +167,7 @@ def test_list_other_url(gl):
def test_create_mixin_missing_attrs(gl):
class M(CreateMixin, FakeManager):
- _create_attrs = base.RequiredOptional(
+ _create_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
@@ -183,10 +184,10 @@ def test_create_mixin_missing_attrs(gl):
@responses.activate
def test_create_mixin(gl):
class M(CreateMixin, FakeManager):
- _create_attrs = base.RequiredOptional(
+ _create_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
- _update_attrs = base.RequiredOptional(required=("foo",), optional=("bam",))
+ _update_attrs = gl_types.RequiredOptional(required=("foo",), optional=("bam",))
url = "http://localhost/api/v4/tests"
responses.add(
@@ -208,10 +209,10 @@ def test_create_mixin(gl):
@responses.activate
def test_create_mixin_custom_path(gl):
class M(CreateMixin, FakeManager):
- _create_attrs = base.RequiredOptional(
+ _create_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
- _update_attrs = base.RequiredOptional(required=("foo",), optional=("bam",))
+ _update_attrs = gl_types.RequiredOptional(required=("foo",), optional=("bam",))
url = "http://localhost/api/v4/others"
responses.add(
@@ -232,7 +233,7 @@ def test_create_mixin_custom_path(gl):
def test_update_mixin_missing_attrs(gl):
class M(UpdateMixin, FakeManager):
- _update_attrs = base.RequiredOptional(
+ _update_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
@@ -249,10 +250,10 @@ def test_update_mixin_missing_attrs(gl):
@responses.activate
def test_update_mixin(gl):
class M(UpdateMixin, FakeManager):
- _create_attrs = base.RequiredOptional(
+ _create_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
- _update_attrs = base.RequiredOptional(required=("foo",), optional=("bam",))
+ _update_attrs = gl_types.RequiredOptional(required=("foo",), optional=("bam",))
url = "http://localhost/api/v4/tests/42"
responses.add(
@@ -293,10 +294,10 @@ def test_update_mixin_uses_post(gl):
@responses.activate
def test_update_mixin_no_id(gl):
class M(UpdateMixin, FakeManager):
- _create_attrs = base.RequiredOptional(
+ _create_attrs = gl_types.RequiredOptional(
required=("foo",), optional=("bar", "baz")
)
- _update_attrs = base.RequiredOptional(required=("foo",), optional=("bam",))
+ _update_attrs = gl_types.RequiredOptional(required=("foo",), optional=("bam",))
url = "http://localhost/api/v4/tests"
responses.add(