summaryrefslogtreecommitdiff
path: root/tests/functional
diff options
context:
space:
mode:
authorNejc Habjan <nejc.habjan@siemens.com>2022-10-22 15:26:26 +0200
committerJohn Villalovos <john@sodarock.com>2022-10-27 08:06:52 -0700
commit5b642a5d4c934f0680fa99079484176d36641861 (patch)
tree4c18c278bdfd630ec3501d388a0a4c8c8aed9e47 /tests/functional
parentee143c9d6df0f1498483236cc228e12132bef132 (diff)
downloadgitlab-5b642a5d4c934f0680fa99079484176d36641861.tar.gz
chore: add basic type checks to functional/api tests
Diffstat (limited to 'tests/functional')
-rw-r--r--tests/functional/api/test_import_export.py2
-rw-r--r--tests/functional/api/test_keys.py2
-rw-r--r--tests/functional/api/test_merge_requests.py2
-rw-r--r--tests/functional/api/test_projects.py2
4 files changed, 4 insertions, 4 deletions
diff --git a/tests/functional/api/test_import_export.py b/tests/functional/api/test_import_export.py
index d4bdd19..32b85c6 100644
--- a/tests/functional/api/test_import_export.py
+++ b/tests/functional/api/test_import_export.py
@@ -45,7 +45,7 @@ def test_project_import_export(gl, project, temp_dir):
raise Exception("Project export taking too much time")
with open(temp_dir / "gitlab-export.tgz", "wb") as f:
- export.download(streamed=True, action=f.write)
+ export.download(streamed=True, action=f.write) # type: ignore[arg-type]
output = gl.projects.import_project(
open(temp_dir / "gitlab-export.tgz", "rb"),
diff --git a/tests/functional/api/test_keys.py b/tests/functional/api/test_keys.py
index 4f2f4ed..a674bfc 100644
--- a/tests/functional/api/test_keys.py
+++ b/tests/functional/api/test_keys.py
@@ -6,7 +6,7 @@ import base64
import hashlib
-def key_fingerprint(key):
+def key_fingerprint(key: str) -> str:
key_part = key.split()[1]
decoded = base64.b64decode(key_part.encode("ascii"))
digest = hashlib.sha256(decoded).digest()
diff --git a/tests/functional/api/test_merge_requests.py b/tests/functional/api/test_merge_requests.py
index da5284e..75afb08 100644
--- a/tests/functional/api/test_merge_requests.py
+++ b/tests/functional/api/test_merge_requests.py
@@ -177,7 +177,7 @@ def test_merge_request_reset_approvals(gitlab_url, project, wait_for_sidekiq):
bot_project = bot_gitlab.projects.get(project.id, lazy=True)
wait_for_sidekiq(timeout=60)
- mr = bot_project.mergerequests.list()[0]
+ mr = bot_project.mergerequests.list()[0] # type: ignore[index]
assert mr.reset_approvals()
diff --git a/tests/functional/api/test_projects.py b/tests/functional/api/test_projects.py
index 81e0831..91319da 100644
--- a/tests/functional/api/test_projects.py
+++ b/tests/functional/api/test_projects.py
@@ -142,7 +142,7 @@ def test_project_forks(gl, project, user):
assert fork_project.forked_from_project["id"] == project.id
forks = project.forks.list()
- assert fork.id in map(lambda fork_project: fork_project.id, forks)
+ assert fork.id in [fork_project.id for fork_project in forks]
def test_project_hooks(project):