summaryrefslogtreecommitdiff
path: root/gitlab/v4
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2022-01-10 18:11:05 -0800
committerJohn L. Villalovos <john@sodarock.com>2022-01-13 10:31:24 -0800
commita2e7c383e10509b6eb0fa8760727036feb0807c8 (patch)
tree934b8e03c90239f1eaa80dcef347e0774ecb589f /gitlab/v4
parent12435d74364ca881373d690eab89d2e2baa62a49 (diff)
downloadgitlab-a2e7c383e10509b6eb0fa8760727036feb0807c8.tar.gz
chore: add EncodedId string class to use to hold URL-encoded paths
Add EncodedId string class. This class returns a URL-encoded string but ensures it will only URL-encode it once even if recursively called. Also added some functional tests of 'lazy' objects to make sure they work.
Diffstat (limited to 'gitlab/v4')
-rw-r--r--gitlab/v4/objects/merge_request_approvals.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
index 2bbd399..45016d5 100644
--- a/gitlab/v4/objects/merge_request_approvals.py
+++ b/gitlab/v4/objects/merge_request_approvals.py
@@ -75,7 +75,7 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
if TYPE_CHECKING:
assert self._parent is not None
- path = f"/projects/{self._parent.get_id()}/approvers"
+ path = f"/projects/{self._parent.encoded_id}/approvers"
data = {"approver_ids": approver_ids, "approver_group_ids": approver_group_ids}
result = self.gitlab.http_put(path, post_data=data, **kwargs)
if TYPE_CHECKING: