summaryrefslogtreecommitdiff
path: root/tests/unit/test_plugin_type_manager.py
diff options
context:
space:
mode:
authorAnthony Sottile <asottile@umich.edu>2021-08-15 18:47:16 -0400
committerAnthony Sottile <asottile@umich.edu>2021-08-15 19:00:43 -0400
commitd34581b83f75e12e2c021577aa2523eea8a9b590 (patch)
treef9312ee5f37d725677028e426a244bb5befe5ca3 /tests/unit/test_plugin_type_manager.py
parent281f3f8b43106023bf3fb160666384394031a9fd (diff)
downloadflake8-d34581b83f75e12e2c021577aa2523eea8a9b590.tar.gz
test using python3.10
Diffstat (limited to 'tests/unit/test_plugin_type_manager.py')
-rw-r--r--tests/unit/test_plugin_type_manager.py21
1 files changed, 7 insertions, 14 deletions
diff --git a/tests/unit/test_plugin_type_manager.py b/tests/unit/test_plugin_type_manager.py
index 4db1ea9..1b823af 100644
--- a/tests/unit/test_plugin_type_manager.py
+++ b/tests/unit/test_plugin_type_manager.py
@@ -34,20 +34,13 @@ def create_mapping_manager_mock(plugins):
return manager_mock
-def create_manager_with_plugins(plugins):
- """Create a fake PluginManager with a plugins dictionary."""
- manager_mock = mock.create_autospec(manager.PluginManager)
- manager_mock.plugins = plugins
- return manager_mock
-
-
class FakeTestType(manager.PluginTypeManager):
"""Fake PluginTypeManager."""
namespace = TEST_NAMESPACE
-@mock.patch("flake8.plugins.manager.PluginManager")
+@mock.patch("flake8.plugins.manager.PluginManager", autospec=True)
def test_instantiates_a_manager(PluginManager): # noqa: N803
"""Verify we create a PluginManager on instantiation."""
FakeTestType()
@@ -55,7 +48,7 @@ def test_instantiates_a_manager(PluginManager): # noqa: N803
PluginManager.assert_called_once_with(TEST_NAMESPACE, local_plugins=None)
-@mock.patch("flake8.plugins.manager.PluginManager")
+@mock.patch("flake8.plugins.manager.PluginManager", autospec=True)
def test_proxies_names_to_manager(PluginManager): # noqa: N803
"""Verify we proxy the names attribute."""
PluginManager.return_value = mock.Mock(names=["T100", "T200", "T300"])
@@ -64,7 +57,7 @@ def test_proxies_names_to_manager(PluginManager): # noqa: N803
assert type_mgr.names == ["T100", "T200", "T300"]
-@mock.patch("flake8.plugins.manager.PluginManager")
+@mock.patch("flake8.plugins.manager.PluginManager", autospec=True)
def test_proxies_plugins_to_manager(PluginManager): # noqa: N803
"""Verify we proxy the plugins attribute."""
PluginManager.return_value = mock.Mock(plugins=["T100", "T200", "T300"])
@@ -86,7 +79,7 @@ def test_generate_call_function():
assert func(plugin) is optmanager
-@mock.patch("flake8.plugins.manager.PluginManager")
+@mock.patch("flake8.plugins.manager.PluginManager", autospec=True)
def test_load_plugins(PluginManager): # noqa: N803
"""Verify load plugins loads *every* plugin."""
# Create a bunch of fake plugins
@@ -191,12 +184,12 @@ def test_provide_options(PluginManager): # noqa: N803
plugin.provide_options.assert_called_with(optmanager, options, [])
-@mock.patch("flake8.plugins.manager.PluginManager")
+@mock.patch("flake8.plugins.manager.PluginManager", autospec=True)
def test_proxy_contains_to_managers_plugins_dict(PluginManager): # noqa: N803
"""Verify that we proxy __contains__ to the manager's dictionary."""
plugins = {"T10%i" % i: create_plugin_mock() for i in range(8)}
# Return our PluginManager mock
- PluginManager.return_value = create_manager_with_plugins(plugins)
+ PluginManager.return_value.plugins = plugins
type_mgr = FakeTestType()
for i in range(8):
@@ -209,7 +202,7 @@ def test_proxies_getitem_to_managers_plugins_dict(PluginManager): # noqa: N803
"""Verify that we can use the PluginTypeManager like a dictionary."""
plugins = {"T10%i" % i: create_plugin_mock() for i in range(8)}
# Return our PluginManager mock
- PluginManager.return_value = create_manager_with_plugins(plugins)
+ PluginManager.return_value.plugins = plugins
type_mgr = FakeTestType()
for i in range(8):