summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorIan Stapleton Cordasco <graffatcolmingov@gmail.com>2021-04-15 09:12:25 -0500
committerIan Stapleton Cordasco <graffatcolmingov@gmail.com>2021-04-15 13:26:08 -0500
commit2bb03083632f59184e71ea8e92a4b2ad6e14e89c (patch)
tree20a661ca6fc0621de73359e90a5c6506bd102144 /src
parent992bb77d2249b835a9bce6fd51e06b789cbd1eda (diff)
downloadflake8-fix-extend-default-ignore.tar.gz
Fix bug for plugins using extend_default_ignorefix-extend-default-ignore
Since Flake8 3.0 we've had the ability for plugins to use `extend_default_ignore` to register codes they want disabled by default. This, however, was a permanent disabling unfortunately. Our code didn't have a way of understanding that this new set of `ignore` codes was actually the 'default' set for that run. Much like the extended_select_list, we now attach extended_ignore_list to be able to confidently determine if the ignore we get in the DecisionEngine is actually the Default Ignore list and what plugins what us to ignore by default. Refs https://github.com/PyCQA/pep8-naming/pull/157
Diffstat (limited to 'src')
-rw-r--r--src/flake8/options/aggregator.py4
-rw-r--r--src/flake8/style_guide.py4
2 files changed, 7 insertions, 1 deletions
diff --git a/src/flake8/options/aggregator.py b/src/flake8/options/aggregator.py
index b53b674..40848a2 100644
--- a/src/flake8/options/aggregator.py
+++ b/src/flake8/options/aggregator.py
@@ -48,6 +48,10 @@ def aggregate_options(
# Extend the default ignore value with the extended default ignore list,
# registered by plugins.
extended_default_ignore = manager.extended_default_ignore.copy()
+ # Let's store our extended default ignore for use by the decision engine
+ default_values.extended_default_ignore = (
+ manager.extended_default_ignore.copy()
+ )
LOG.debug(
"Extended default ignore list: %s", list(extended_default_ignore)
)
diff --git a/src/flake8/style_guide.py b/src/flake8/style_guide.py
index a34afd7..d862691 100644
--- a/src/flake8/style_guide.py
+++ b/src/flake8/style_guide.py
@@ -177,7 +177,9 @@ class DecisionEngine:
reverse=True,
)
)
- self.using_default_ignore = set(self.ignored) == set(defaults.IGNORE)
+ self.using_default_ignore = set(self.ignored) == set(
+ defaults.IGNORE
+ ).union(options.extended_default_ignore)
self.using_default_select = set(self.selected) == set(defaults.SELECT)
def _in_all_selected(self, code: str) -> bool: