summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDirk Makowski <dmakowski@gmx.net>2013-02-18 20:06:29 +0100
committerDirk Makowski <dmakowski@gmx.net>2013-02-18 20:06:29 +0100
commite49a429be4451995ae13a7bf71299f0ed41d8d04 (patch)
tree1cca79e5628a108395ad4dd4d298960bce11a147
parent9662e850ab618ff9f1bf2b814531eef20af73093 (diff)
downloadfeedgenerator-e49a429be4451995ae13a7bf71299f0ed41d8d04.tar.gz
Use OrderedDict for feed XML attribs
-rw-r--r--feedgenerator/django/utils/feedgenerator.py7
-rw-r--r--tests_feedgenerator/test_feedgenerator.py4
2 files changed, 9 insertions, 2 deletions
diff --git a/feedgenerator/django/utils/feedgenerator.py b/feedgenerator/django/utils/feedgenerator.py
index 54bc7ed..6ef46de 100644
--- a/feedgenerator/django/utils/feedgenerator.py
+++ b/feedgenerator/django/utils/feedgenerator.py
@@ -24,6 +24,7 @@ http://web.archive.org/web/20110718035220/http://diveintomark.org/archives/2004/
from __future__ import unicode_literals
import datetime
+import collections
try:
from urllib.parse import urlparse
except ImportError: # Python 2
@@ -220,8 +221,10 @@ class RssFeed(SyndicationFeed):
handler.endElement("rss")
def rss_attributes(self):
- return {"version": self._version,
- "xmlns:atom": "http://www.w3.org/2005/Atom"}
+ d = collections.OrderedDict()
+ d["xmlns:atom"] = "http://www.w3.org/2005/Atom"
+ d["version"] = self._version
+ return d
def write_items(self, handler):
for item in self.items:
diff --git a/tests_feedgenerator/test_feedgenerator.py b/tests_feedgenerator/test_feedgenerator.py
index ccbf111..fc6b66f 100644
--- a/tests_feedgenerator/test_feedgenerator.py
+++ b/tests_feedgenerator/test_feedgenerator.py
@@ -51,6 +51,9 @@ def build_expected_result(feed, expected_result, encoding):
class TestFeedGenerator(unittest.TestCase):
+ def setUp(self):
+ self.maxDiff = None
+
def test_000_types(self):
ty = str if six.PY3 else unicode
for k, v in FIXT_FEED.items():
@@ -60,6 +63,7 @@ class TestFeedGenerator(unittest.TestCase):
self.assertEqual(type(EXPECTED_RESULT), ty)
def test_001_string_results(self):
+ #import ipdb; ipdb.set_trace()
feed = feedgenerator.Rss201rev2Feed(**FIXT_FEED)
feed.add_item(**FIXT_ITEM)
result = feed.writeString(ENCODING)