summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2022-01-17 12:29:04 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2022-01-17 12:29:04 -0500
commit6c0ddf452940245fa6c11c02959252ecb7eb677d (patch)
tree94339d8bbf635523711d1e0da1fc61edb275e96e
parentfa0fa49ef07bf2bdfa9e68626a9de1668ea4691f (diff)
downloaddogpile-cache-6c0ddf452940245fa6c11c02959252ecb7eb677d.tar.gz
update pep484 tests
staticmethod can now be type-qualified, so static checkers are complaining. however we don't want to do that here because it's going to fail in Python 3.7. just use an ignore type for the one place we do this right now. Add pep484 tox target as we are getting jenkins to target this for all projects. Change-Id: Ic4db0fc7dd0bfe01308027c911f4dcb288bb169e
-rw-r--r--dogpile/cache/api.py8
-rw-r--r--tox.ini10
2 files changed, 13 insertions, 5 deletions
diff --git a/dogpile/cache/api.py b/dogpile/cache/api.py
index f54bd68..0717d43 100644
--- a/dogpile/cache/api.py
+++ b/dogpile/cache/api.py
@@ -152,7 +152,7 @@ class CacheBackend:
"""
- serializer: Union[None, Serializer, staticmethod] = None
+ serializer: Union[None, Serializer] = None
"""Serializer function that will be used by default if not overridden
by the region.
@@ -160,7 +160,7 @@ class CacheBackend:
"""
- deserializer: Union[None, Deserializer, staticmethod] = None
+ deserializer: Union[None, Deserializer] = None
"""deserializer function that will be used by default if not overridden
by the region.
@@ -446,10 +446,10 @@ class CacheBackend:
class DefaultSerialization:
- serializer: Union[None, Serializer, staticmethod] = staticmethod(
+ serializer: Union[None, Serializer] = staticmethod( # type: ignore
pickle.dumps
)
- deserializer: Union[None, Deserializer, staticmethod] = staticmethod(
+ deserializer: Union[None, Deserializer] = staticmethod( # type: ignore
pickle.loads
)
diff --git a/tox.ini b/tox.ini
index 59715fb..d11ecd4 100644
--- a/tox.ini
+++ b/tox.ini
@@ -51,7 +51,8 @@ commands=
sitepackages=False
usedevelop=True
-[testenv:mypy]
+
+[testenv:pep484]
basepython = python3
deps=
mypy
@@ -64,6 +65,13 @@ deps=
types-decorator
commands = mypy ./dogpile/
+[testenv:mypy]
+basepython = python3
+deps=
+ {[testenv:pep484]deps}
+commands = mypy ./dogpile/
+
+
# thanks to https://julien.danjou.info/the-best-flake8-extensions/
[testenv:pep8]
basepython = python3