1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
|
from django.test import TestCase
from .models import (
Event,
Movie,
Package,
PackageNullFK,
Person,
Screening,
ScreeningNullFK,
)
# These are tests for #16715. The basic scheme is always the same: 3 models with
# 2 relations. The first relation may be null, while the second is non-nullable.
# In some cases, Django would pick the wrong join type for the second relation,
# resulting in missing objects in the queryset.
#
# Model A
# | (Relation A/B : nullable)
# Model B
# | (Relation B/C : non-nullable)
# Model C
#
# Because of the possibility of NULL rows resulting from the LEFT OUTER JOIN
# between Model A and Model B (i.e. instances of A without reference to B),
# the second join must also be LEFT OUTER JOIN, so that we do not ignore
# instances of A that do not reference B.
#
# Relation A/B can either be an explicit foreign key or an implicit reverse
# relation such as introduced by one-to-one relations (through multi-table
# inheritance).
class NestedForeignKeysTests(TestCase):
@classmethod
def setUpTestData(cls):
cls.director = Person.objects.create(name="Terry Gilliam / Terry Jones")
cls.movie = Movie.objects.create(
title="Monty Python and the Holy Grail", director=cls.director
)
# This test failed in #16715 because in some cases INNER JOIN was selected
# for the second foreign key relation instead of LEFT OUTER JOIN.
def test_inheritance(self):
Event.objects.create()
Screening.objects.create(movie=self.movie)
self.assertEqual(len(Event.objects.all()), 2)
self.assertEqual(len(Event.objects.select_related("screening")), 2)
# This failed.
self.assertEqual(len(Event.objects.select_related("screening__movie")), 2)
self.assertEqual(len(Event.objects.values()), 2)
self.assertEqual(len(Event.objects.values("screening__pk")), 2)
self.assertEqual(len(Event.objects.values("screening__movie__pk")), 2)
self.assertEqual(len(Event.objects.values("screening__movie__title")), 2)
# This failed.
self.assertEqual(
len(
Event.objects.values("screening__movie__pk", "screening__movie__title")
),
2,
)
# Simple filter/exclude queries for good measure.
self.assertEqual(Event.objects.filter(screening__movie=self.movie).count(), 1)
self.assertEqual(Event.objects.exclude(screening__movie=self.movie).count(), 1)
# These all work because the second foreign key in the chain has null=True.
def test_inheritance_null_FK(self):
Event.objects.create()
ScreeningNullFK.objects.create(movie=None)
ScreeningNullFK.objects.create(movie=self.movie)
self.assertEqual(len(Event.objects.all()), 3)
self.assertEqual(len(Event.objects.select_related("screeningnullfk")), 3)
self.assertEqual(len(Event.objects.select_related("screeningnullfk__movie")), 3)
self.assertEqual(len(Event.objects.values()), 3)
self.assertEqual(len(Event.objects.values("screeningnullfk__pk")), 3)
self.assertEqual(len(Event.objects.values("screeningnullfk__movie__pk")), 3)
self.assertEqual(len(Event.objects.values("screeningnullfk__movie__title")), 3)
self.assertEqual(
len(
Event.objects.values(
"screeningnullfk__movie__pk", "screeningnullfk__movie__title"
)
),
3,
)
self.assertEqual(
Event.objects.filter(screeningnullfk__movie=self.movie).count(), 1
)
self.assertEqual(
Event.objects.exclude(screeningnullfk__movie=self.movie).count(), 2
)
def test_null_exclude(self):
screening = ScreeningNullFK.objects.create(movie=None)
ScreeningNullFK.objects.create(movie=self.movie)
self.assertEqual(
list(ScreeningNullFK.objects.exclude(movie__id=self.movie.pk)), [screening]
)
# This test failed in #16715 because in some cases INNER JOIN was selected
# for the second foreign key relation instead of LEFT OUTER JOIN.
def test_explicit_ForeignKey(self):
Package.objects.create()
screening = Screening.objects.create(movie=self.movie)
Package.objects.create(screening=screening)
self.assertEqual(len(Package.objects.all()), 2)
self.assertEqual(len(Package.objects.select_related("screening")), 2)
self.assertEqual(len(Package.objects.select_related("screening__movie")), 2)
self.assertEqual(len(Package.objects.values()), 2)
self.assertEqual(len(Package.objects.values("screening__pk")), 2)
self.assertEqual(len(Package.objects.values("screening__movie__pk")), 2)
self.assertEqual(len(Package.objects.values("screening__movie__title")), 2)
# This failed.
self.assertEqual(
len(
Package.objects.values(
"screening__movie__pk", "screening__movie__title"
)
),
2,
)
self.assertEqual(Package.objects.filter(screening__movie=self.movie).count(), 1)
self.assertEqual(
Package.objects.exclude(screening__movie=self.movie).count(), 1
)
# These all work because the second foreign key in the chain has null=True.
def test_explicit_ForeignKey_NullFK(self):
PackageNullFK.objects.create()
screening = ScreeningNullFK.objects.create(movie=None)
screening_with_movie = ScreeningNullFK.objects.create(movie=self.movie)
PackageNullFK.objects.create(screening=screening)
PackageNullFK.objects.create(screening=screening_with_movie)
self.assertEqual(len(PackageNullFK.objects.all()), 3)
self.assertEqual(len(PackageNullFK.objects.select_related("screening")), 3)
self.assertEqual(
len(PackageNullFK.objects.select_related("screening__movie")), 3
)
self.assertEqual(len(PackageNullFK.objects.values()), 3)
self.assertEqual(len(PackageNullFK.objects.values("screening__pk")), 3)
self.assertEqual(len(PackageNullFK.objects.values("screening__movie__pk")), 3)
self.assertEqual(
len(PackageNullFK.objects.values("screening__movie__title")), 3
)
self.assertEqual(
len(
PackageNullFK.objects.values(
"screening__movie__pk", "screening__movie__title"
)
),
3,
)
self.assertEqual(
PackageNullFK.objects.filter(screening__movie=self.movie).count(), 1
)
self.assertEqual(
PackageNullFK.objects.exclude(screening__movie=self.movie).count(), 2
)
# Some additional tests for #16715. The only difference is the depth of the
# nesting as we now use 4 models instead of 3 (and thus 3 relations). This
# checks if promotion of join types works for deeper nesting too.
class DeeplyNestedForeignKeysTests(TestCase):
@classmethod
def setUpTestData(cls):
cls.director = Person.objects.create(name="Terry Gilliam / Terry Jones")
cls.movie = Movie.objects.create(
title="Monty Python and the Holy Grail", director=cls.director
)
def test_inheritance(self):
Event.objects.create()
Screening.objects.create(movie=self.movie)
self.assertEqual(len(Event.objects.all()), 2)
self.assertEqual(
len(Event.objects.select_related("screening__movie__director")), 2
)
self.assertEqual(len(Event.objects.values()), 2)
self.assertEqual(len(Event.objects.values("screening__movie__director__pk")), 2)
self.assertEqual(
len(Event.objects.values("screening__movie__director__name")), 2
)
self.assertEqual(
len(
Event.objects.values(
"screening__movie__director__pk", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
len(
Event.objects.values(
"screening__movie__pk", "screening__movie__director__pk"
)
),
2,
)
self.assertEqual(
len(
Event.objects.values(
"screening__movie__pk", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
len(
Event.objects.values(
"screening__movie__title", "screening__movie__director__pk"
)
),
2,
)
self.assertEqual(
len(
Event.objects.values(
"screening__movie__title", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
Event.objects.filter(screening__movie__director=self.director).count(), 1
)
self.assertEqual(
Event.objects.exclude(screening__movie__director=self.director).count(), 1
)
def test_explicit_ForeignKey(self):
Package.objects.create()
screening = Screening.objects.create(movie=self.movie)
Package.objects.create(screening=screening)
self.assertEqual(len(Package.objects.all()), 2)
self.assertEqual(
len(Package.objects.select_related("screening__movie__director")), 2
)
self.assertEqual(len(Package.objects.values()), 2)
self.assertEqual(
len(Package.objects.values("screening__movie__director__pk")), 2
)
self.assertEqual(
len(Package.objects.values("screening__movie__director__name")), 2
)
self.assertEqual(
len(
Package.objects.values(
"screening__movie__director__pk", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
len(
Package.objects.values(
"screening__movie__pk", "screening__movie__director__pk"
)
),
2,
)
self.assertEqual(
len(
Package.objects.values(
"screening__movie__pk", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
len(
Package.objects.values(
"screening__movie__title", "screening__movie__director__pk"
)
),
2,
)
self.assertEqual(
len(
Package.objects.values(
"screening__movie__title", "screening__movie__director__name"
)
),
2,
)
self.assertEqual(
Package.objects.filter(screening__movie__director=self.director).count(), 1
)
self.assertEqual(
Package.objects.exclude(screening__movie__director=self.director).count(), 1
)
|
