summaryrefslogtreecommitdiff
path: root/django
Commit message (Collapse)AuthorAgeFilesLines
* Refs #32339 -- Fixed super() call in deprecated renderers.HEADmainCarlton Gibson2023-05-171-2/+2
| | | | | | | Missing function call `()` leads to: TypeError: descriptor '__init__' of 'super' object needs an argument Regression in b209518089131c6b4afd18b1d9c320ba3521c5ab.
* Fixed #34568 -- Made makemigrations --update respect --name option.Mariusz Felisiak2023-05-171-3/+2
| | | Thanks David Sanders for the report.
* Fixed #34570 -- Silenced noop deferral of many-to-many and GFK.Simon Charette2023-05-171-1/+9
| | | | | | | | | While deferring many-to-many and GFK has no effect, the previous implementation of QuerySet.defer() ignore them instead of crashing. Regression in b3db6c8dcb5145f7d45eff517bcd96460475c879. Thanks Paco Martínez for the report.
* Fixed #34539 -- Restored get_prep_value() call when adapting JSONFields.Julie Rymer2023-05-161-0/+2
| | | | Regression in 5c23d9f0c32f166c81ecb6f3f01d5077a6084318.
* Fixed #470 -- Added support for database defaults on fields.Ian Foote2023-05-1217-22/+271
| | | | | | | | Special thanks to Hannes Ljungberg for finding multiple implementation gaps. Thanks also to Simon Charette, Adam Johnson, and Mariusz Felisiak for reviews.
* Fixed #34558 -- Fixed QuerySet.bulk_create() crash with Now() on Oracle.Mariusz Felisiak2023-05-111-0/+5
|
* Fixed #34553 -- Fixed improper % escaping of literal in constraints.Simon Charette2023-05-103-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Proper escaping of % in string literals used when defining constaints was attempted (a8b3f96f6) by overriding quote_value of Postgres and Oracle schema editor. The same approach was used when adding support for constraints to the MySQL/MariaDB backend (1fc2c70). Later on it was discovered that this approach was not appropriate and that a preferable one was to pass params=None when executing the constraint creation DDL to avoid any form of interpolation in the first place (42e8cf47). When the second patch was applied the corrective of the first were not removed which caused % literals to be unnecessary doubled. This flew under the radar because the existings test were crafted in a way that consecutive %% didn't catch regressions. This commit introduces an extra test for __exact lookups which highlights more adequately % doubling problems but also adjust a previous __endswith test to cover % doubling problems (%\% -> %%\%%). Thanks Thomas Kolar for the report. Refs #32369, #30408, #30593.
* Fixed #34554 -- Fixed Reverse(Value(…)) crash on Oracle.Mariusz Felisiak2023-05-101-1/+2
|
* Removed obsolete docstring from Field.db_returning.Lily Foote2023-05-101-4/+1
| | | | It's also supported on SQLite 3.35+ and MariaDB 10.5+.
* Refs #34534 -- Reduced Add/RemoveConstraint and Add/RenameIndex operations ↵Akash Kumar Sen2023-05-091-0/+12
| | | | when optimizing migrations.
* Moved SQLite DatabaseSchemaEditor.add_field()'s comment to the correct line.Mariusz Felisiak2023-05-091-2/+1
|
* Fixed #34544 -- Avoided DBMS_LOB.SUBSTR() wrapping with IS NULL condition on ↵Mariusz Felisiak2023-05-082-7/+6
| | | | | | | | | Oracle. Regression in 09ffc5c1212d4ced58b708cbbf3dfbfb77b782ca. Thanks Michael Smith for the report. This also reverts commit 1e4da439556cdd69eb9f91e07f99cf77997e70d2.
* Refs #27236 -- Made more cosmetic edits to Meta.index_together deprecation.Mariusz Felisiak2023-05-053-4/+5
|
* Fixed #34535 -- Fixed SQLite dbshell crash on pathlib.Path when handling ↵Jan Pieter Waagmeester2023-05-041-1/+1
| | | | | | CommandError. Regression in 5b884d45ac5b76234eca614d90c83b347294c332.
* Fixed CVE-2023-31047, Fixed #31710 -- Prevented potential bypass of ↵Mariusz Felisiak2023-05-031-1/+25
| | | | | | | | | validation when uploading multiple files using one form field. Thanks Moataz Al-Sharida and nawaik for reports. Co-authored-by: Shai Berger <shai@platonix.com> Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
* Fixed #34529, Refs #34525 -- Reduced index operations with ↵Mariusz Felisiak2023-05-031-0/+65
| | | | | | | | Meta.indexes/index_together when optimizing migrations. This makes squashing migrations an available path for changing Meta.index_together, which is deprecated, to Meta.indexes. Follow up to f81032572107846922745b68d5b7191058fdd5f5.
* Fixed #34523 -- Fixed TransactionManagementError in ↵Mariusz Felisiak2023-05-031-3/+0
| | | | | | | | | | | | | | QuerySet.update_or_create() with MyISAM storage engine. QuerySet.update_or_create() uses nested atomic to handle possible integrity errors taking savepoints as way to mark back the connection as usable. Savepoints are not returned when uses_savepoints/can_release_savepoints feature flags are set to False. As a consequence, QuerySet.update_or_create() assumed the outer atomic block is tainted and raised TransactionManagementError. This commit partly reverts 331a460f8f2e4f447b68fba491464b68c9b21fd1. Thanks gatello-s for the report.
* Fixed #34517 -- Avoided connection post_init signal to ImageField without ↵Orhan Hirsch2023-05-031-5/+4
| | | | width/height fields.
* Refs #31369 -- Improved hint message in NullBooleanField's deprecation warning.Paul Brown2023-05-021-1/+1
|
* Fixed #34513 -- Added system check for relational fields in ↵Bakdolot2023-05-021-3/+4
| | | | ModelAdmin.list_display.
* Fixed #34515 -- Made LocaleMiddleware prefer language from paths when i18n ↵Mariusz Felisiak2023-05-025-27/+20
| | | | | | | | | | | | | | patterns are used. Regression in 94e7f471c4edef845a4fe5e3160132997b4cca81. This reverts commit 94e7f471c4edef845a4fe5e3160132997b4cca81 (refs #34069) and partly reverts commit 3b4728310a7a64f8fcc548163b0aa5f98a5c78f5. Thanks Anthony Baillard for the report. Co-Authored-By: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
* Fixed #34528 -- Reduced Add/RemoveIndex operations when optimizing migrations.Mariusz Felisiak2023-05-011-0/+5
|
* Fixed #33759 -- Avoided unnecessary subquery in QuerySet.delete() with ↵4the4ryushin2023-05-013-1/+8
| | | | self-referential subqueries if supported.
* Fixed #34380 -- Allowed specifying a default URL scheme in forms.URLField.Coen van der Kamp2023-04-281-3/+17
| | | | This also deprecates "http" as the default scheme.
* Avoided creating default form fields in fields_for_model() when declared on ↵Mariusz Felisiak2023-04-271-2/+10
| | | | form.
* Fixed #34518 -- Fixed crash of random() template filter with an empty list.David Sanders2023-04-261-1/+4
|
* Fixed #34512 -- Restored breadcrumbs on admin app index view.Mariusz Felisiak2023-04-261-8/+10
| | | | | Thanks Adam (ataylor32) for the report. Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.
* Replaced docutils link by PyPI reference.Claude Paroz2023-04-251-1/+1
|
* Refs #31949 -- Made @never_cache and @cache_control() decorators to work ↵Ben Lomax2023-04-251-26/+44
| | | | | | with async functions. Thanks Carlton Gibson and Mariusz Felisiak for reviews.
* Updated admin's XRegExp to 5.1.1.Andreas Dickow2023-04-253-3955/+5286
|
* Fixed #34481 -- Added system check for reverse related fields in ↵Bakdolot2023-04-241-2/+5
| | | | ModelAdmin.list_display.
* Refs #33766 -- Removed sql.Query.build_filtered_relation_q().Simon Charette2023-04-242-32/+15
| | | | It was a copy of sql.Query._add_q that avoided JOIN updates.
* Refs #33766 -- Removed unused Join.equals().Simon Charette2023-04-241-7/+0
| | | | | It's unused now that the specialized FilteredRelation.as_sql logic is no more.
* Fixed #33766 -- Resolved FilteredRelation.condition at referencing time.Simon Charette2023-04-243-48/+58
| | | | | | | | | | | The previous implementation resolved condition at Join compilation time which required introducing a specialized expression resolving mode to alter the join reuse logic solely during that phase. FilteredRelation.condition is now resolved when the relation is first referenced which maintains the existing behavior while allowing the removal of the specialized resolving mode and address an issue where conditions couldn't spawn new joins.
* Refs #34462 -- Fixed queryset antipattern when processing object deletion.nessita2023-04-221-1/+1
|
* Fixed #34506 -- Fixed margin of ClearableFileInput in admin CSS.Mariusz Felisiak2023-04-212-5/+0
| | | Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
* Fixed #34505 -- Skipped varchar_pattern_ops/text_pattern_ops index creation ↵Petter Friberg2023-04-211-1/+3
| | | | when db_collation is set in related field.
* Fixed #34488 -- Made ClearableFileInput preserve "Clear" checked attribute ↵Marcelo Galigniana2023-04-212-1/+4
| | | | when form is invalid.
* Fixed #34496 -- Fixed handling source maps with data URI in ↵Hielke Walinga2023-04-211-2/+2
| | | | | | ManifestStaticFilesStorage. Regression in 781b44240a06f0c868254f40f36ce46c927f56d1.
* Corrected exception type in safe_join()'s docstring.David Sanders2023-04-201-2/+2
|
* Added Irish locale formats.Michael J Walsh2023-04-192-0/+37
| | | Thanks Tom Moran for the report.
* Refs #16055 -- Deprecated ↵David Wobrock2023-04-183-0/+31
| | | | get_joining_columns()/get_reverse_joining_columns() methods.
* Fixed #16055 -- Fixed crash when filtering against char/text GenericRelation ↵David Wobrock2023-04-186-11/+54
| | | | relation on PostgreSQL.
* Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect get_list_filter().sarahboyce2023-04-173-5/+27
| | | | Thank you Simon Meers for the initial patch.
* Refs #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates on ↵Mariusz Felisiak2023-04-141-3/+6
| | | | | | different days and interval less than 1 day. Follow up to 813015d67e2557fa859a07930a9becec4e5f64a0. Regression in 8d67e16493c903adc9d049141028bc0fff43f8c8.
* Fixed #34486 -- Fixed DatabaseOperations.compose_sql() crash with no ↵Scott Macpherson2023-04-141-1/+2
| | | | | | existing database connection on PostgreSQL. Regression in 09ffc5c1212d4ced58b708cbbf3dfbfb77b782ca.
* Fixed #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates and ↵nessita2023-04-131-1/+2
| | | | | | | interval less than 1 day. Regression in 8d67e16493c903adc9d049141028bc0fff43f8c8. Thanks Lorenzo Peña for the report.
* Fixed typo in ManagementUtility.autocomplete()'s docstring.Vitor [Bux]baum2023-04-131-2/+2
|
* Refs #34482 -- Reverted "Fixed #32969 -- Fixed pickling HttpResponse and ↵Mariusz Felisiak2023-04-122-26/+8
| | | | | | | | subclasses." This reverts commit d7f5bfd241666c0a76e90208da1e9ef81aec44db. Thanks Márton Salomváry for the report.
* Fixed #34484, Refs #34482 -- Reverted "Fixed #29186 -- Fixed pickling ↵Mariusz Felisiak2023-04-123-27/+2
| | | | | | | | HttpRequest and subclasses." This reverts commit 6220c445c40a6a7f4d442de8bde2628346153963. Thanks Adam Johnson and Márton Salomváry for reports.