diff options
author | David Smith <smithdc@gmail.com> | 2020-06-17 07:35:09 +0100 |
---|---|---|
committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2020-06-18 21:43:20 +0200 |
commit | 27c09043da52ca1f02605bf28600bfd5ace95ae4 (patch) | |
tree | b9fb0d8d11a736943e4bab5ea2982bb8d96d6477 /tests/validators | |
parent | 26a413507abb38f7eee4cf62f2ee9727fdc7bf8d (diff) | |
download | django-27c09043da52ca1f02605bf28600bfd5ace95ae4.tar.gz |
Refs #31670 -- Renamed whitelist argument and attribute of EmailValidator.
Diffstat (limited to 'tests/validators')
-rw-r--r-- | tests/validators/tests.py | 44 |
1 files changed, 42 insertions, 2 deletions
diff --git a/tests/validators/tests.py b/tests/validators/tests.py index 5127bfecf5..c94ec251d6 100644 --- a/tests/validators/tests.py +++ b/tests/validators/tests.py @@ -16,7 +16,8 @@ from django.core.validators import ( validate_ipv4_address, validate_ipv6_address, validate_ipv46_address, validate_slug, validate_unicode_slug, ) -from django.test import SimpleTestCase +from django.test import SimpleTestCase, ignore_warnings +from django.utils.deprecation import RemovedInDjango41Warning try: from PIL import Image # noqa @@ -50,7 +51,7 @@ TEST_DATA = [ (validate_email, 'example@valid-with-hyphens.com', None), (validate_email, 'test@domain.with.idn.tld.उदाहरण.परीक्षा', None), (validate_email, 'email@localhost', None), - (EmailValidator(whitelist=['localdomain']), 'email@localdomain', None), + (EmailValidator(allowlist=['localdomain']), 'email@localdomain', None), (validate_email, '"test@test"@example.com', None), (validate_email, 'example@atm.%s' % ('a' * 63), None), (validate_email, 'example@%s.atm' % ('a' * 63), None), @@ -510,3 +511,42 @@ class TestValidatorEquality(TestCase): ProhibitNullCharactersValidator(message='message', code='code1'), ProhibitNullCharactersValidator(message='message', code='code2') ) + + +class DeprecationTests(SimpleTestCase): + @ignore_warnings(category=RemovedInDjango41Warning) + def test_whitelist(self): + validator = EmailValidator(whitelist=['localdomain']) + self.assertEqual(validator.domain_allowlist, ['localdomain']) + self.assertIsNone(validator('email@localdomain')) + self.assertEqual(validator.domain_allowlist, validator.domain_whitelist) + + def test_whitelist_warning(self): + msg = "The whitelist argument is deprecated in favor of allowlist." + with self.assertRaisesMessage(RemovedInDjango41Warning, msg): + EmailValidator(whitelist='localdomain') + + @ignore_warnings(category=RemovedInDjango41Warning) + def test_domain_whitelist(self): + validator = EmailValidator() + validator.domain_whitelist = ['mydomain'] + self.assertEqual(validator.domain_allowlist, ['mydomain']) + self.assertEqual(validator.domain_allowlist, validator.domain_whitelist) + + def test_domain_whitelist_access_warning(self): + validator = EmailValidator() + msg = ( + 'The domain_whitelist attribute is deprecated in favor of ' + 'domain_allowlist.' + ) + with self.assertRaisesMessage(RemovedInDjango41Warning, msg): + validator.domain_whitelist + + def test_domain_whitelist_set_warning(self): + validator = EmailValidator() + msg = ( + 'The domain_whitelist attribute is deprecated in favor of ' + 'domain_allowlist.' + ) + with self.assertRaisesMessage(RemovedInDjango41Warning, msg): + validator.domain_whitelist = ['mydomain'] |