summaryrefslogtreecommitdiff
path: root/tests/sessions_tests
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2018-11-26 14:01:27 -0500
committerTim Graham <timograham@gmail.com>2018-11-27 09:49:02 -0500
commit0f212db29d361ec6219b170198b7c94d0bb3f719 (patch)
treeb4a1a93f3d5b725ed9d08896892f1a3f5e191ab7 /tests/sessions_tests
parent7f63b894c02effb09c15ab0b40d28b89553b8e37 (diff)
downloaddjango-0f212db29d361ec6219b170198b7c94d0bb3f719.tar.gz
Made reused RequestFactory instances class attributes.
Diffstat (limited to 'tests/sessions_tests')
-rw-r--r--tests/sessions_tests/tests.py21
1 files changed, 11 insertions, 10 deletions
diff --git a/tests/sessions_tests/tests.py b/tests/sessions_tests/tests.py
index c213628dbb..733f5adb1d 100644
--- a/tests/sessions_tests/tests.py
+++ b/tests/sessions_tests/tests.py
@@ -625,10 +625,11 @@ class CacheSessionTests(SessionTestsMixin, unittest.TestCase):
class SessionMiddlewareTests(TestCase):
+ request_factory = RequestFactory()
@override_settings(SESSION_COOKIE_SECURE=True)
def test_secure_session_cookie(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -642,7 +643,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_HTTPONLY=True)
def test_httponly_session_cookie(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -660,7 +661,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_SAMESITE='Strict')
def test_samesite_session_cookie(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse()
middleware = SessionMiddleware()
middleware.process_request(request)
@@ -670,7 +671,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_HTTPONLY=False)
def test_no_httponly_session_cookie(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -687,7 +688,7 @@ class SessionMiddlewareTests(TestCase):
)
def test_session_save_on_500(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Horrible error')
response.status_code = 500
middleware = SessionMiddleware()
@@ -704,7 +705,7 @@ class SessionMiddlewareTests(TestCase):
def test_session_update_error_redirect(self):
path = '/foo/'
- request = RequestFactory().get(path)
+ request = self.request_factory.get(path)
response = HttpResponse()
middleware = SessionMiddleware()
@@ -723,7 +724,7 @@ class SessionMiddlewareTests(TestCase):
middleware.process_response(request, response)
def test_session_delete_on_end(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -750,7 +751,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_DOMAIN='.example.local', SESSION_COOKIE_PATH='/example/')
def test_session_delete_on_end_with_custom_domain_and_path(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -778,7 +779,7 @@ class SessionMiddlewareTests(TestCase):
)
def test_flush_empty_without_session_cookie_doesnt_set_cookie(self):
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@@ -799,7 +800,7 @@ class SessionMiddlewareTests(TestCase):
If a session is emptied of data but still has a key, it should still
be updated.
"""
- request = RequestFactory().get('/')
+ request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()