diff options
author | Simon Charette <charette.s@gmail.com> | 2017-11-29 01:06:45 -0500 |
---|---|---|
committer | Tim Graham <timograham@gmail.com> | 2017-11-30 09:28:44 -0500 |
commit | e50add6ca1605dcc06c8c5a5770342779a4d5124 (patch) | |
tree | 9591b2b0315302b9a81a395f19167b765a27faf4 /tests/serializers | |
parent | f0a68c25118786d47041d0a435b2afa953be3c86 (diff) | |
download | django-e50add6ca1605dcc06c8c5a5770342779a4d5124.tar.gz |
Fixed #28856 -- Fixed a regression in caching of a GenericForeignKey pointing to a MTI model.
Regression in b9f8635f58ad743995cad2081b3dc395e55761e5.
Diffstat (limited to 'tests/serializers')
-rw-r--r-- | tests/serializers/test_xml.py | 6 | ||||
-rw-r--r-- | tests/serializers/tests.py | 6 |
2 files changed, 1 insertions, 11 deletions
diff --git a/tests/serializers/test_xml.py b/tests/serializers/test_xml.py index ea9677d87f..b11cfdd864 100644 --- a/tests/serializers/test_xml.py +++ b/tests/serializers/test_xml.py @@ -30,12 +30,6 @@ class XmlSerializerTestCase(SerializersTestBase, TestCase): </django-objects>""" # NOQA @staticmethod - def _comparison_value(value): - # The XML serializer handles everything as strings, so comparisons - # need to be performed on the stringified value - return str(value) - - @staticmethod def _validate_output(serial_str): try: minidom.parseString(serial_str) diff --git a/tests/serializers/tests.py b/tests/serializers/tests.py index 0ea60f0f64..66fc2ef40c 100644 --- a/tests/serializers/tests.py +++ b/tests/serializers/tests.py @@ -90,10 +90,6 @@ class SerializerRegistrationTests(SimpleTestCase): class SerializersTestBase: serializer_name = None # Set by subclasses to the serialization format name - @staticmethod - def _comparison_value(value): - return value - def setUp(self): sports = Category.objects.create(name="Sports") music = Category.objects.create(name="Music") @@ -193,7 +189,7 @@ class SerializersTestBase: self.assertFalse(self._get_field_values(serial_str, 'author')) for obj in serializers.deserialize(self.serializer_name, serial_str): - self.assertEqual(obj.object.pk, self._comparison_value(self.joe.pk)) + self.assertEqual(obj.object.pk, self.joe.pk) def test_serialize_field_subset(self): """Output can be restricted to a subset of fields""" |