diff options
author | Nick Pope <nick@nickpope.me.uk> | 2022-02-22 09:29:38 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-02-22 10:29:38 +0100 |
commit | 847f46e9bf88964484c8b76a10af753ea1018311 (patch) | |
tree | 13aced534cbae373f47cce8fce1444ad0e8e01d3 /tests/serializers | |
parent | 7ba6ebe9149ae38257d70100e8bfbfd0da189862 (diff) | |
download | django-847f46e9bf88964484c8b76a10af753ea1018311.tar.gz |
Removed redundant QuerySet.all() calls in docs and tests.
Most QuerySet methods are mapped onto the Manager and, in general,
it isn't necessary to call .all() on the manager.
Diffstat (limited to 'tests/serializers')
-rw-r--r-- | tests/serializers/tests.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/serializers/tests.py b/tests/serializers/tests.py index d995b36e04..48899cb3fb 100644 --- a/tests/serializers/tests.py +++ b/tests/serializers/tests.py @@ -282,7 +282,7 @@ class SerializersTestBase: with self.assertNumQueries(3): serializers.serialize( self.serializer_name, - Article.objects.all().prefetch_related("categories", "meta_data"), + Article.objects.prefetch_related("categories", "meta_data"), ) # One query for the Article table, and two m2m queries for each # article. @@ -361,7 +361,7 @@ class SerializersTestBase: for obj in deserial_objs: self.assertFalse(obj.object.id) obj.save() - self.assertEqual(Category.objects.all().count(), 5) + self.assertEqual(Category.objects.count(), 5) def test_deterministic_mapping_ordering(self): """Mapping such as fields should be deterministically ordered. (#24558)""" @@ -454,9 +454,9 @@ class SerializersTransactionTestBase: obj.save() for model_cls in (Category, Author, Article): - self.assertEqual(model_cls.objects.all().count(), 1) + self.assertEqual(model_cls.objects.count(), 1) art_obj = Article.objects.all()[0] - self.assertEqual(art_obj.categories.all().count(), 1) + self.assertEqual(art_obj.categories.count(), 1) self.assertEqual(art_obj.author.name, "Agnes") |