Refs #32948, Refs #32946 -- Used Q.create() internally for dynamic Q() objects.

Node.create() which has a compatible signature with Node.__init__()
takes in a single `children` argument rather than relying in unpacking
*args in Q.__init__() which calls Node.__init__().

In addition, we were often needing to unpack iterables into *args and
can instead pass a list direct to Node.create().

1 files changed, 9 insertions, 0 deletions

diff --git a/tests/queries/test_q.py b/tests/queries/test_q.py
index 289305d33f..923846b5a3 100644
--- a/tests/queries/test_q.py
+++ b/tests/queries/test_q.py
@@ -216,6 +216,15 @@ class QTests(SimpleTestCase):
         flatten = list(q.flatten())
         self.assertEqual(len(flatten), 7)
 
+    def test_create_helper(self):
+        items = [("a", 1), ("b", 2), ("c", 3)]
+        for connector in [Q.AND, Q.OR, Q.XOR]:
+            with self.subTest(connector=connector):
+                self.assertEqual(
+                    Q.create(items, connector=connector),
+                    Q(*items, _connector=connector),
+                )
+
 
 class QCheckTests(TestCase):
     def test_basic(self):