summaryrefslogtreecommitdiff
path: root/tests/middleware_exceptions
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2018-04-28 15:20:27 +0200
committerTim Graham <timograham@gmail.com>2018-05-07 09:34:00 -0400
commit607970f31cc07c317f2ebb684c8f3ccc36a95b3e (patch)
treeb11c0976fb161d3339025400b048a27ce5e2f19f /tests/middleware_exceptions
parent7d3fe36c626a3268413eb86d37920f132eb4a54f (diff)
downloaddjango-607970f31cc07c317f2ebb684c8f3ccc36a95b3e.tar.gz
Replaced django.test.utils.patch_logger() with assertLogs().
Thanks Tim Graham for the review.
Diffstat (limited to 'tests/middleware_exceptions')
-rw-r--r--tests/middleware_exceptions/tests.py17
1 files changed, 7 insertions, 10 deletions
diff --git a/tests/middleware_exceptions/tests.py b/tests/middleware_exceptions/tests.py
index 0c39f09f91..783257c057 100644
--- a/tests/middleware_exceptions/tests.py
+++ b/tests/middleware_exceptions/tests.py
@@ -1,7 +1,6 @@
from django.conf import settings
from django.core.exceptions import MiddlewareNotUsed
from django.test import RequestFactory, SimpleTestCase, override_settings
-from django.test.utils import patch_logger
from . import middleware as mw
@@ -138,26 +137,24 @@ class MiddlewareNotUsedTests(SimpleTestCase):
@override_settings(MIDDLEWARE=['middleware_exceptions.tests.MyMiddleware'])
def test_log(self):
- with patch_logger('django.request', 'debug') as calls:
+ with self.assertLogs('django.request', 'DEBUG') as cm:
self.client.get('/middleware_exceptions/view/')
- self.assertEqual(len(calls), 1)
self.assertEqual(
- calls[0],
+ cm.records[0].getMessage(),
"MiddlewareNotUsed: 'middleware_exceptions.tests.MyMiddleware'"
)
@override_settings(MIDDLEWARE=['middleware_exceptions.tests.MyMiddlewareWithExceptionMessage'])
def test_log_custom_message(self):
- with patch_logger('django.request', 'debug') as calls:
+ with self.assertLogs('django.request', 'DEBUG') as cm:
self.client.get('/middleware_exceptions/view/')
- self.assertEqual(len(calls), 1)
self.assertEqual(
- calls[0],
+ cm.records[0].getMessage(),
"MiddlewareNotUsed('middleware_exceptions.tests.MyMiddlewareWithExceptionMessage'): spam eggs"
)
@override_settings(DEBUG=False)
def test_do_not_log_when_debug_is_false(self):
- with patch_logger('django.request', 'debug') as calls:
- self.client.get('/middleware_exceptions/view/')
- self.assertEqual(len(calls), 0)
+ with self.assertRaisesMessage(AssertionError, 'no logs'):
+ with self.assertLogs('django.request', 'DEBUG'):
+ self.client.get('/middleware_exceptions/view/')