summaryrefslogtreecommitdiff
path: root/tests/middleware
diff options
context:
space:
mode:
authorViktor Lomakin <vl.dart.py@gmail.com>2019-10-09 12:20:17 +0300
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2019-10-10 09:51:05 +0200
commitee6b17187fbf19d498c16bd46ec6dd6aaf86f453 (patch)
treebc38aecdf701be369eecc22bd226357b82d1e390 /tests/middleware
parent3cd3bebe8921e14b911b36b2a1cbceef8fb6294e (diff)
downloaddjango-ee6b17187fbf19d498c16bd46ec6dd6aaf86f453.tar.gz
Fixed #30812 -- Made ConditionalGetMiddleware set ETag only for responses with non-empty content.
Diffstat (limited to 'tests/middleware')
-rw-r--r--tests/middleware/tests.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/middleware/tests.py b/tests/middleware/tests.py
index def313c5f7..6b6eded24d 100644
--- a/tests/middleware/tests.py
+++ b/tests/middleware/tests.py
@@ -452,6 +452,12 @@ class ConditionalGetMiddlewareTest(SimpleTestCase):
res = StreamingHttpResponse(['content'])
self.assertFalse(ConditionalGetMiddleware().process_response(self.req, res).has_header('ETag'))
+ def test_no_etag_response_empty_content(self):
+ res = HttpResponse()
+ self.assertFalse(
+ ConditionalGetMiddleware().process_response(self.req, res).has_header('ETag')
+ )
+
def test_no_etag_no_store_cache(self):
self.resp['Cache-Control'] = 'No-Cache, No-Store, Max-age=0'
self.assertFalse(ConditionalGetMiddleware().process_response(self.req, self.resp).has_header('ETag'))