summaryrefslogtreecommitdiff
path: root/tests/logging_tests
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2018-11-26 14:01:27 -0500
committerTim Graham <timograham@gmail.com>2018-11-27 09:49:02 -0500
commit0f212db29d361ec6219b170198b7c94d0bb3f719 (patch)
treeb4a1a93f3d5b725ed9d08896892f1a3f5e191ab7 /tests/logging_tests
parent7f63b894c02effb09c15ab0b40d28b89553b8e37 (diff)
downloaddjango-0f212db29d361ec6219b170198b7c94d0bb3f719.tar.gz
Made reused RequestFactory instances class attributes.
Diffstat (limited to 'tests/logging_tests')
-rw-r--r--tests/logging_tests/tests.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/tests/logging_tests/tests.py b/tests/logging_tests/tests.py
index d48b3cd8db..37010ab7d0 100644
--- a/tests/logging_tests/tests.py
+++ b/tests/logging_tests/tests.py
@@ -246,6 +246,7 @@ class CallbackFilterTest(SimpleTestCase):
class AdminEmailHandlerTest(SimpleTestCase):
logger = logging.getLogger('django')
+ request_factory = RequestFactory()
def get_admin_email_handler(self, logger):
# AdminEmailHandler does not get filtered out
@@ -307,8 +308,7 @@ class AdminEmailHandlerTest(SimpleTestCase):
orig_filters = admin_email_handler.filters
try:
admin_email_handler.filters = []
- rf = RequestFactory()
- request = rf.get('/')
+ request = self.request_factory.get('/')
self.logger.error(
message, token1, token2,
extra={
@@ -388,9 +388,8 @@ class AdminEmailHandlerTest(SimpleTestCase):
"""
handler = self.get_admin_email_handler(self.logger)
record = self.logger.makeRecord('name', logging.ERROR, 'function', 'lno', 'message', None, None)
- rf = RequestFactory()
url_path = '/ยบ'
- record.request = rf.get(url_path)
+ record.request = self.request_factory.get(url_path)
handler.emit(record)
self.assertEqual(len(mail.outbox), 1)
msg = mail.outbox[0]