diff options
author | Tomer Chachamu <tomer@festicket.com> | 2017-11-24 15:48:15 +0000 |
---|---|---|
committer | Tim Graham <timograham@gmail.com> | 2017-12-30 11:38:11 -0500 |
commit | 9bc4d90d1a8c4d1dee54115a0995a7b6fca8635b (patch) | |
tree | f83f4124172f350a31c1777d7bfa24bffacd4b3c /tests/generic_relations | |
parent | da82939e5a31dea21a4f4d5085dfcd449fcbed3a (diff) | |
download | django-9bc4d90d1a8c4d1dee54115a0995a7b6fca8635b.tar.gz |
Fixed #14642 -- Fixed generic inline formsets crash when using save_as_new=True.
Diffstat (limited to 'tests/generic_relations')
-rw-r--r-- | tests/generic_relations/test_forms.py | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/tests/generic_relations/test_forms.py b/tests/generic_relations/test_forms.py index bed31034be..99ae882693 100644 --- a/tests/generic_relations/test_forms.py +++ b/tests/generic_relations/test_forms.py @@ -200,3 +200,40 @@ id="id_generic_relations-taggeditem-content_type-object_id-1-id" /></p>""" % tag self.assertTrue(formset.is_valid()) new_obj, = formset.save() self.assertNotIsInstance(new_obj.obj, ProxyRelatedModel) + + def test_initial_count(self): + GenericFormSet = generic_inlineformset_factory(TaggedItem) + data = { + 'form-TOTAL_FORMS': '3', + 'form-INITIAL_FORMS': '3', + 'form-MAX_NUM_FORMS': '', + } + formset = GenericFormSet(data=data, prefix='form') + self.assertEqual(formset.initial_form_count(), 3) + formset = GenericFormSet(data=data, prefix='form', save_as_new=True) + self.assertEqual(formset.initial_form_count(), 0) + + def test_save_as_new(self): + """ + The save_as_new parameter creates new items that are associated with + the object. + """ + lion = Animal.objects.create(common_name='Lion', latin_name='Panthera leo') + yellow = lion.tags.create(tag='yellow') + hairy = lion.tags.create(tag='hairy') + GenericFormSet = generic_inlineformset_factory(TaggedItem) + data = { + 'form-TOTAL_FORMS': '3', + 'form-INITIAL_FORMS': '2', + 'form-MAX_NUM_FORMS': '', + 'form-0-id': str(yellow.pk), + 'form-0-tag': 'hunts', + 'form-1-id': str(hairy.pk), + 'form-1-tag': 'roars', + } + formset = GenericFormSet(data, instance=lion, prefix='form', save_as_new=True) + self.assertTrue(formset.is_valid()) + tags = formset.save() + self.assertEqual([tag.tag for tag in tags], ['hunts', 'roars']) + hunts, roars = tags + self.assertSequenceEqual(lion.tags.order_by('tag'), [hairy, hunts, roars, yellow]) |