diff options
| author | Nick Pope <nick.pope@flightdataservices.com> | 2019-10-21 09:55:05 +0100 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-10-29 12:37:30 +0100 |
| commit | 7552de7866dcd270a0f353b007b4aceaa7f3ff3e (patch) | |
| tree | 2e84292833853d9659671ed304cb32d5acef5f90 /tests/file_uploads | |
| parent | a6cb8ec3895a72bfb7f8e62d4b05dd5de6b738af (diff) | |
| download | django-7552de7866dcd270a0f353b007b4aceaa7f3ff3e.tar.gz | |
Used more specific unittest assertions in tests.
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
Diffstat (limited to 'tests/file_uploads')
| -rw-r--r-- | tests/file_uploads/tests.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/file_uploads/tests.py b/tests/file_uploads/tests.py index 7b31d369b2..db9b915d35 100644 --- a/tests/file_uploads/tests.py +++ b/tests/file_uploads/tests.py @@ -479,8 +479,9 @@ class FileUploadTests(TestCase): try: self.client.post('/upload_errors/', post_data) except reference_error.__class__ as err: - self.assertFalse( - str(err) == str(reference_error), + self.assertNotEqual( + str(err), + str(reference_error), "Caught a repeated exception that'll cause an infinite loop in file uploads." ) except Exception as err: |