summaryrefslogtreecommitdiff
path: root/tests/expressions
diff options
context:
space:
mode:
authorMariusz Felisiak <felisiak.mariusz@gmail.com>2023-01-13 09:49:28 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2023-01-17 11:49:15 +0100
commit94ad46e9d8077d8fadce991af85be657b4a4e2a0 (patch)
treec5561c9331ba0497e1042a769633381bd6b9b0f6 /tests/expressions
parent98756c685ee173bbd43f21ed0553f808be835ce5 (diff)
downloaddjango-94ad46e9d8077d8fadce991af85be657b4a4e2a0.tar.gz
Refs #33543 -- Made Expression.asc()/desc() and OrderBy raise ValueError when nulls_first/nulls_last=False is passed.
Per deprecation timeline.
Diffstat (limited to 'tests/expressions')
-rw-r--r--tests/expressions/tests.py17
1 files changed, 5 insertions, 12 deletions
diff --git a/tests/expressions/tests.py b/tests/expressions/tests.py
index 7db6013819..8a3b5d45f5 100644
--- a/tests/expressions/tests.py
+++ b/tests/expressions/tests.py
@@ -70,7 +70,6 @@ from django.test.utils import (
isolate_apps,
register_lookup,
)
-from django.utils.deprecation import RemovedInDjango50Warning
from django.utils.functional import SimpleLazyObject
from .models import (
@@ -2632,18 +2631,12 @@ class OrderByTests(SimpleTestCase):
)
def test_nulls_false(self):
- # These tests will catch ValueError in Django 5.0 when passing False to
- # nulls_first and nulls_last becomes forbidden.
- # msg = "nulls_first and nulls_last values must be True or None."
- msg = (
- "Passing nulls_first=False or nulls_last=False is deprecated, use None "
- "instead."
- )
- with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
+ msg = "nulls_first and nulls_last values must be True or None."
+ with self.assertRaisesMessage(ValueError, msg):
OrderBy(F("field"), nulls_first=False)
- with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
+ with self.assertRaisesMessage(ValueError, msg):
OrderBy(F("field"), nulls_last=False)
- with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
+ with self.assertRaisesMessage(ValueError, msg):
F("field").asc(nulls_first=False)
- with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
+ with self.assertRaisesMessage(ValueError, msg):
F("field").desc(nulls_last=False)